| Summary: | ValueSet has rendering issues in RTL interface | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | yousifjkadom |
| Component: | UI | Assignee: | Not Assigned <libreoffice-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | major | CC: | amiadb, barta, chris.sherlock79, goodlinuxuser, ilmari.lauhakangas, momonasmon, philipz85, safaalfulaij |
| Priority: | high | Keywords: | bibisected, bisected, regression |
| Version: | 4.4.0.3 release | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | target:5.1.0 target:5.0.2 target:4.4.6 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 43808, 99671 | ||
| Attachments: |
file.1
file.2 file.3 file.4 file.5 file.6 screencast |
||
|
Description
yousifjkadom
2015-02-14 20:23:37 UTC
Screenshot? Hi. Sorry for dely in reply. Unfortuantly I have no screenshoot program available to me on my PC. You can test bug by yourself. Just switch UI to Arabic & try font color & you will see it very obvious. Best. (In reply to yousifjkadom from comment #2) > Hi. Sorry for dely in reply. Unfortuantly I have no screenshoot program > available to me on my PC. > You can test bug by yourself. Just switch UI to Arabic & try font color & > you will see it very obvious. > Best. If you are on Windows, you can press the PrtScn (Print Screen) button on your keyboard and then open Windows Paint and paste your screenshot there. Save as .jpg and attach here. Set to NEEDINFO. Change back to UNCONFIRMED after you have provided the screenshot. Created attachment 113739 [details]
file.1
Created attachment 113740 [details]
file.2
Created attachment 113741 [details]
file.3
Created attachment 113742 [details]
file.4
Created attachment 113743 [details]
file.5
Created attachment 113745 [details]
file.6
These screenshot taken using version 4.4.1.2 Confirmed on 4.4 daily the problem with the color drop down. Confirmed on 4.4 daily the bullets dialog problem that isnt there in 4.3.5. I believe the changes made by maxim in bug 85804 may have contributed to this. Created attachment 113746 [details]
screencast
Testing the same issue on linux, it seems like there is some visual corruption in all of these places, including the bullet drop down as well.
None of this happens when i'm in the english UI.
Bug is still esisting without any fix on version 5.0.0.5!! This is just UI bug & still not fixed till now! Version 5 become available & this bug not fixed!! This disapointing. *** Bug 91853 has been marked as a duplicate of this bug. *** *** Bug 91148 has been marked as a duplicate of this bug. *** All the affected controls are ValueSet based, and I can confirm this in other ValueSet based controls as well, so probably there is some shared problem in it. Increasing importance to high-major, because it makes several key features unusable with RTL interface. Tip for QA: You don't need RTL langpack for this. It's enough to export SAL_RTL_ENABLED=1 before starting LO. *** Bug 88973 has been marked as a duplicate of this bug. *** Well, this is the bad commit: commit 28effca640fff262866d1d3ada6e51a3821a6725 Author: Chris Sherlock <chris.sherlock79@gmail.com> Date: Sat Nov 15 17:05:11 2014 +1100 vcl: SalGraphics::mirror() - always use GetGraphicsWidth() There's never a case where we need to get the width from VirtualDevice, we really should only get it from the SalGraphics instance. This vastly simplifies matters. Change-Id: I8bae9c163fcb0ce5d064d802c2783437124ebcb2 Reviewed-on: https://gerrit.libreoffice.org/12473 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com> Reverting it fixes the bug, without any visual side effects. I submitted the revert to gerrit: https://gerrit.libreoffice.org/17937/ I'm not familiar with this code, so I'll wait for someone who is familiar to review the patch. CCing Chris to see if he can give his input on this. Maxim Monastirsky committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=d2c09305084c218facdd282c3232a9929b81e342 tdf#89381 Revert "vcl: SalGraphics::mirror() - always use GetGraphicsWidth()" It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Maxim Monastirsky committed a patch related to this issue. It has been pushed to "libreoffice-5-0": http://cgit.freedesktop.org/libreoffice/core/commit/?id=287aaa33c27a651ace5c37ed71f1dad4f1b28379&h=libreoffice-5-0 tdf#89381 Revert "vcl: SalGraphics::mirror() - always use GetGraphicsWidth()" It will be available in 5.0.2. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Cherry-picked it for 4.4 and 5.0.1. Maxim Monastirsky committed a patch related to this issue. It has been pushed to "libreoffice-4-4": http://cgit.freedesktop.org/libreoffice/core/commit/?id=df3b4a1604339eadab2f320eaf0e79ba8f4b6806&h=libreoffice-4-4 tdf#89381 Revert "vcl: SalGraphics::mirror() - always use GetGraphicsWidth()" It will be available in 4.4.6. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. *** Bug 93939 has been marked as a duplicate of this bug. *** I test version 5.0.2 This bug is fixed. Thank you. Migrating Whiteboard tags to Keywords: (bibisected) [NinjaEdit] |