Bug 89536

Summary:	Database preview on Writer fails
Product:	LibreOffice	Reporter:	Julien Nabet <serval2412>
Component:	Base	Assignee:	Not Assigned <libreoffice-bugs>
Status:	RESOLVED FIXED
Severity:	major	CC:	noelgrandin, raal, serval2412
Priority:	high	Keywords:	haveBacktrace, regression
Version:	4.5.0.0.alpha0+ Master
Hardware:	Other
OS:	All
See Also:	https://bugs.documentfoundation.org/show_bug.cgi?id=89601
Whiteboard:	target:4.5.0
Crash report or crash signature:		Regression By:

Description Julien Nabet 2015-02-21 18:42:08 UTC

On pc Debian x86-64 with master sources updated yesterday, I can't see anymore the preview of table.

1) Open Writer
2) Click F4
3) Select "Bibliography" then "Tables" and "biblio"

Current behaviour:
Nothing appears on top right pane

Expected behaviour:
we should see some contents of the table

Comment 1 Julien Nabet 2015-02-21 19:52:26 UTC

With this patch, the problem is fixed:

diff --git a/forms/source/component/Columns.hxx b/forms/source/component/Columns.hxx
index d619b6e..669d156 100644
--- a/forms/source/component/Columns.hxx
+++ b/forms/source/component/Columns.hxx
@@ -85,8 +85,8 @@ public:
     virtual void SAL_CALL disposing(const ::com::sun::star::lang::EventObject& _rSource) throw(::com::sun::star::uno::RuntimeException, std::exception) SAL_OVERRIDE;
 
     // XPersistObject
-    void SAL_CALL write(const ::com::sun::star::uno::Reference< ::com::sun::star::io::XObjectOutputStream>& _rxOutStream);
-    void SAL_CALL read(const ::com::sun::star::uno::Reference< ::com::sun::star::io::XObjectInputStream>& _rxInStream);
+    virtual void SAL_CALL write(const ::com::sun::star::uno::Reference< ::com::sun::star::io::XObjectOutputStream>& _rxOutStream);
+    virtual void SAL_CALL read(const ::com::sun::star::uno::Reference< ::com::sun::star::io::XObjectInputStream>& _rxInStream);

Noel: noticing http://cgit.freedesktop.org/libreoffice/core/commit/?id=b44cbb26efe1d0b0950b1e1613e131b506dc3876, could you take a look? I hope there's no other regression.

Comment 2 Julien Nabet 2015-02-21 20:17:49 UTC

Sorry Noel, forget my previous comment. I had launched 4.3.3 instead of the local build :-(
Put it back to UNCONFIRMED

Comment 3 Julien Nabet 2015-02-21 22:03:53 UTC

Here's an exception from console logs
warn:legacy.osl:14853:1:dbaccess/source/ui/browser/unodatbr.cxx:819: caught an exception!
in function:virtual bool dbaui::SbaTableQueryBrowser::InitializeGridModel(const com::sun::star::uno::Reference<com::sun::star::form::XFormComponent>&)
type: com.sun.star.beans.UnknownPropertyException

gdb gives a bt:
#0  cppu::OPropertySetHelper::setPropertyValue (this=0x6d7e638, rPropertyName="FormatsSupplier", rValue=
    uno::Any {<com::sun::star::uno::XInterface> = {_vptr.XInterface = 0x6e14d48}, <No data fields>})
    at /home/julien/compile-libreoffice/libreoffice/cppuhelper/source/propshlp.cxx:267
#1  0x00002aaad8aed150 in dbaui::SbaTableQueryBrowser::InitializeGridModel (this=0x6ba0d20, xGrid=uno::Reference to (frm::OGridControlModel *) 0x6ca5900)
    at /home/julien/compile-libreoffice/libreoffice/dbaccess/source/ui/browser/unodatbr.cxx:805
#2  0x00002aaad8af7d01 in dbaui::SbaTableQueryBrowser::implLoadAnything (this=0x6ba0d20, _rDataSourceName="Bibliography", _rCommand="biblio", _nCommandType=0, 
    _bEscapeProcessing=true, _rxConnection=...) at /home/julien/compile-libreoffice/libreoffice/dbaccess/source/ui/browser/unodatbr.cxx:2407
#3  0x00002aaad8af97a5 in dbaui::SbaTableQueryBrowser::implSelect (this=0x6ba0d20, _pEntry=0x6d138c0)
    at /home/julien/compile-libreoffice/libreoffice/dbaccess/source/ui/browser/unodatbr.cxx:2693
#4  0x00002aaad8af8555 in dbaui::SbaTableQueryBrowser::OnSelectionChange (this=0x6ba0d20)
    at /home/julien/compile-libreoffice/libreoffice/dbaccess/source/ui/browser/unodatbr.cxx:2496
#5  0x00002aaad8af850f in dbaui::SbaTableQueryBrowser::LinkStubOnSelectionChange (pThis=0x6ba0d20, pCaller=0x0)
    at /home/julien/compile-libreoffice/libreoffice/dbaccess/source/ui/browser/unodatbr.cxx:2494
#6  0x00002aaad8a4a03c in Link::Call (this=0x6e24d30, pCaller=0x0) at /home/julien/compile-libreoffice/libreoffice/include/tools/link.hxx:139
#7  0x00002aaad8b173af in dbaui::DBTreeListBox::OnTimeOut (this=0x6e24790) at /home/julien/compile-libreoffice/libreoffice/dbaccess/source/ui/control/dbtreelistbox.cxx:660
#8  0x00002aaad8b17379 in dbaui::DBTreeListBox::LinkStubOnTimeOut (pThis=0x6e24790, pCaller=0x6e24c80)
    at /home/julien/compile-libreoffice/libreoffice/dbaccess/source/ui/control/dbtreelistbox.cxx:656

Comment 4 A (Andy) 2015-02-22 10:50:11 UTC

In LO 4.4.0.3 (Win 8.1) it showed contents.

Comment 5 raal 2015-02-22 18:33:31 UTC

I can confirm with Version: 4.5.0.0.alpha0+
Build ID: 52fa2e97dfef1a5f27aaee6af7ed80800641b86c
TinderBox: Linux-rpm_deb-x86_64@46-TDF, Branch:master, Time: 2015-02-22_01:03:18

Comment 6 Julien Nabet 2015-02-27 18:50:48 UTC

On pc Debian x86-64 with master sources updated today, I don't reproduce this.

I put it as WFM.

Comment 7 Julien Nabet 2015-02-27 22:44:19 UTC

I made the test again, it's ok thanks to Stephan's fix http://cgit.freedesktop.org/libreoffice/core/commit/?id=fa6c09877ed6502593de2f73541d91f31c8feea1