| Summary: | ODF export: Writer saves invalid XML when there are multiple annotation ranges (style tag has two office:name attributes) | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | ts <mail> |
| Component: | Writer | Assignee: | Caolán McNamara <caolan.mcnamara> |
| Status: | RESOLVED FIXED | ||
| Severity: | critical | CC: | ilmari.lauhakangas, mattcopp, michael.stahl |
| Priority: | highest | Keywords: | regression |
| Version: | 4.3.0.4 release | ||
| Hardware: | Other | ||
| OS: | Linux (All) | ||
| Whiteboard: | odf odf_validation target:4.4.4 target:5.0.0 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 108198 | ||
| Attachments: |
testcase
Small document with changes and notes: example of an opening error. |
||
|
Description
ts
2015-02-24 14:48:06 UTC
Sorry, forgot to include version: Version: 4.3.3.2 Build-ID: 430m0(Build:2) on Ubuntu 14.10 64 bit, German language (In reply to Titus Stahl from comment #0) > This has happened twice with the same document. (I can provide the document > but it is kind of semi-confidential, don't want to upload it here). You could try this: https://wiki.documentfoundation.org/Anonymizing_a_document#Sanitize_file_text Set to NEEDINFO. Change back to UNCONFIRMED after you have an example file for us. Thanks. Created attachment 117709 [details]
testcase
this is a testcase. basically, if I change anything in the document and save it, it cannot be opened anymore.
Version: 4.4.2.2
Build-ID: 40m0(Build:2)
Gebietsschema: de_DE
on Ubuntu 15.04, 64-bit
Created attachment 117902 [details]
Small document with changes and notes: example of an opening error.
This type of error is very common if you keep changes and notes in the same document. Changing notes will very, very often crash the document.
Went back from 5.0 to 4.4 because of the large number of crashes with documents like these.
Running on Ubuntu 15.04 64 bits.
a regression from the AOO imported range annotation feature, commit 0761f81643a6890457e9ef7d913ab5c88c2593a4 this was fixed in LO 4.4.4 by commit 804ec2289115a65c74ddff478b7469801debf7e4 Author: Caolán McNamara <caolanm@redhat.com> AuthorDate: Wed Apr 22 14:10:38 2015 +0100 fix assert on export of ooo63141-1.doc to odt if bAutoStyles is true then the mbDoSomething of the SvXMLElementExport is false, and the ctor/dtor doesn't do anything so any attributes added to the exporter are not cleared by the SvXMLElementExport dtor so only add the attribute if bAutoStyles if false and might as well extend the block to cover the use of SvXMLElementExport and use the other ctor which defaults mbDoSomething on |