| Summary: | change from postfix operator++/-- to prefix operator++/-- | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Markus Mohrhard <markus.mohrhard> |
| Component: | LibreOffice | Assignee: | Not Assigned <libreoffice-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | ahmadsamir1194, gulsah.1004, h3734236, langhoffwilliam, robinson.libreoffice, serval2412 |
| Priority: | medium | Keywords: | difficultyBeginner, easyHack, skillCpp, topicCleanup |
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | target:4.5.0 target:5.2.0 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 90564 | ||
| Attachments: | Patch for Bug ver1 | ||
|
Description
Markus Mohrhard
2015-03-01 16:31:00 UTC
I want to work on this issue. But what advantage will we get by changing postfix to prefix. Can you Please explain that as it is my 1st bug. Thanks for your help. the prefix version is faster as it does not create a temporary object. See e.g. http://stackoverflow.com/questions/24901/is-there-a-performance-difference-between-i-and-i-in-c and for iterators you are in the non-native type case. I searched google and I find that prefix gives slightly better performance than the postfix.So,this issue is workable. I will soon commit a patch. Thanks Following Lovekesh's comment, let's put this one to ASSIGNED Created attachment 113834 [details] Patch for Bug ver1 Here is my first patch for LibreOffice Project. Bugfix for Bug # 89756. Lovekesh: it could be useful you submit your patch on gerrit, see https://wiki.documentfoundation.org/Development/GetInvolved#Preparing_patches Since the last information message has written two weeks ago, I assign this error myself and I working on it. Hi Markus I want to someting about commit style. I have to change code in many different file. Should i do micro commit for every file or a one commit includes all of the changes? I sent following patch for this bug: https://gerrit.libreoffice.org/#/c/14903/ Gulsah Kose committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=2db08b9ed6427bfa2c7d611b1a7294cb77c6e9b9 tdf#89756 Switched postfix to prefix operator++/-- It will be available in 4.5.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. does this still need work on it? i dont really understand how the pick a easy hack works As Gulsah Kose didn't fix all the mentioned files, I fixed the rest and uploaded my patch here https://gerrit.libreoffice.org/#/c/14975/4 Comment on attachment 113834 [details] Patch for Bug ver1 The attached patch is huge and certainly doesnt apply any more cleanly. Please use gerrit in the future as suggested in comment 6. As such, marking the patch as obsolete as it cant be merged as-is. Migrating Whiteboard tags to Keywords: (EasyHack DifficultyBeginner SkillCpp TopicCleanup ) [NinjaEdit] Is this still being worked on? I'm new to development and I'd like to work on it if thats okay. Resetting owner, as works seems to be stopped. Gerrit patch is abandoned. (In reply to langhoffwilliam from comment #15) > Is this still being worked on? I'm new to development and I'd like to work > on it if thats okay. No problem, you can work on it! :-) Here's the start page to contribute about dev for LO beginners: https://wiki.documentfoundation.org/Development erdemdemirkapi committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=3294af80ab39488188ffe6c762bf1a0aaf84a201 tdf#89756 swich postfix to prefix operators It will be available in 5.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. jan iversen committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=de368b7783dff197ae279e0720c61efb2e0ff274 Revert "tdf#89756 swich postfix to prefix operators" It will be available in 5.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Have we already fixed the occurrences mentioned in the original comment? Are there only simple integer or pointer ++/-- operators left? In that case I suggest we resolve this bug as fixed. Otherwise we will just get suggestions that mechanically blindly change all post-increments to pre-increments without taking the difference in semantics into account, and thus introducing bugs in the cases where it does make a difference. following suggestion from Tor followed by direct discussions. I will cleanup the gerrit patches (which are faulty) Remove LibreOffice Dev List from CC on EasyHacks (curtailing excessive email to list) [NinjaEdit] |