| Summary: | DOCX: dont save custom.xml if its empty | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Yousuf Philips (jay) (retired) <philipz85> |
| Component: | Writer | Assignee: | Julien Nabet <serval2412> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | serval2412 |
| Priority: | medium | Keywords: | filter:docx |
| Version: | 4.5.0.0.alpha0+ Master | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | target:4.5.0 target:4.4.2 | ||
| Crash report or crash signature: | Regression By: | ||
|
Description
Yousuf Philips (jay) (retired)
2015-03-03 02:52:36 UTC
On pc Debian x86-64 with master sources updated today, I could reproduce this. Julien Nabet committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=97c9bc9fada9cdfff956101a4a5e264b4dba58be tdf#89791: DOCX: don't save custom.xml if it's empty It will be available in 4.5.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. For 4.4 branch: https://gerrit.libreoffice.org/#/c/14815/ (I don't think it worth it to cherry-pick the patch for 4.3 since it's not a crash or something annoying) Julien Nabet committed a patch related to this issue. It has been pushed to "libreoffice-4-4": http://cgit.freedesktop.org/libreoffice/core/commit/?id=ddb0bdef30dfb609378b73eb1a429943078bd611&h=libreoffice-4-4 tdf#89791: DOCX: don't save custom.xml if it's empty It will be available in 4.4.2. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Thanks for fixing this Julien. (In reply to Julien Nabet from comment #4) > (I don't think it worth it to cherry-pick the patch for 4.3 since it's not a > crash or something annoying) Totally agree. :D Julien Nabet committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=009762b05131760144dbd2af8900ee2b84077564 Related tdf#89791: Add unit test It will be available in 4.5.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Migrating Whiteboard tags to Keywords: (filter:docx) [NinjaEdit] |