| Summary: | ODF import: Frame area / background color not loaded | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Andrea M. <dgumo> |
| Component: | Writer | Assignee: | Caolán McNamara <caolan.mcnamara> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | caolan.mcnamara, fdbugs, jean-philippe.aizier, laurentlepoittevin, mango.wodzak, michael.stahl, paddy, stgohi-lobugs |
| Priority: | medium | Keywords: | bibisected, bisected, regression |
| Version: | 4.4.1.2 release | ||
| Hardware: | x86 (IA32) | ||
| OS: | All | ||
| See Also: |
https://bugs.documentfoundation.org/show_bug.cgi?id=86578 https://bugs.documentfoundation.org/show_bug.cgi?id=80468 https://bugs.documentfoundation.org/show_bug.cgi?id=90640 https://bugs.documentfoundation.org/show_bug.cgi?id=34585 |
||
| Whiteboard: | odf target:5.0.0 target:4.4.3 | ||
| Crash report or crash signature: | Regression By: | ||
| Attachments: | a related example | ||
|
Description
Andrea M.
2015-03-20 16:49:18 UTC
I use LibreOffice 4.4.1, italian version. For me not reproducible with LO 4.4.1.2. Win 8.1. Maybe a Linux only issue. Note: I supposed, because you did not mention it, that you saved it as an odt-file? But when I tested it I experienced another bug for me. If I save it as a docx-file, close and reopen it, then I have only a white and a black frame. @Andrea: Do you have the same? I would open another bug report for this too. @Andrea: Maybe I have to correct my comment. With drawing a frame did you mean the rectangle drawing shape or INSERT -> FRAME? Because with the last I could reproduce it and in this case it was a misunderstanding from my side. INSERT -> FRAME Another strange thing is that the frame area color is ok saving the text as docx file. Then, if you reopen the docx file and save it as odt file, the new file odt is ok. This could be a temporary workaround for overcoming the problem @Andrea: Thanks for your fast reply. Reproducible with LO 4.4.1.2, Win 8.1 Steps Done: 1. Open WRITER 2. Go to INSERT -> FRAME and press OK to insert a frame 3. Go to the AREA section under PROPERTIES in the Sidebar and select FILL = Colour and as colour select Black 4. Click with the mouse outside the frame into the document to deselect the frame (now it has no longer the green squares for selection) 5. Click with the mouse inside the frame (inside the inner frame of the frame), now you have the blinking cursor to insert a text 6. Write a word and press CTRL + A to select it 7. Change the font colour to white in the CHARACTER section under PROPERTIES 8. Go to FILE -> SAVE AS and save the file as an odt file 9. After you have saved it, close it and reopen it Result: You have only a white frame. -> Problem: The font colour of the text is saved but not the area colour of the frame. This problem only happens if you save it as an odt file (with rtf, doc, docx the area colour is saved). *** Bug 90479 has been marked as a duplicate of this bug. *** This seems more a file open problem than file save - adjusted title After the below commit, the frame background colour isn't loaded. Adding Cc: to caolanm@redhat.com; Could you possibly take a look at this? Thanks (seems also somehow related to bug 86578, but this specific issue is more recent) commit 5aa360cae0383f270c12708e7e94179a7fde6711 Author: Caolán McNamara <caolanm@redhat.com> AuthorDate: Mon Sep 29 16:25:27 2014 +0100 Commit: Caolán McNamara <caolanm@redhat.com> CommitDate: Mon Sep 29 16:31:32 2014 +0100 Resolves: fdo#80468 and fdo#81223 image/frame backgrounds wrong writer has code to fill in missing new properties from the old properties if they exist. But xmloff is stripping them out before they get there. Don't strip them out, and add in a missing check for one of the archaic bg colors and add a regression test for fdo#81223 Change-Id: I9a541a9bee0a01c90f2c33383f1144ecd8b0bfff Created attachment 114778 [details]
a related example
The transparency of this gradient also goes missing
*** Bug 89730 has been marked as a duplicate of this bug. *** *** Bug 87369 has been marked as a duplicate of this bug. *** Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-4-4": http://cgit.freedesktop.org/libreoffice/core/commit/?id=5c17754f824987b26b3aa2f126b383f117b2e63e&h=libreoffice-4-4 Resolves: tdf#90130 don't clobber new solid-color on seeing old transparency It will be available in 4.4.3. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Just compiled and tested and I can confirm the problem is gone. Thank you very much for fixing this bug! :-) A new related bug has been introduced: see bug #90640. Caolán McNamara committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=11730ab931e67e26efd8a7f46dff17c2b8a97e2c Resolves: tdf#90130 don't clobber new solid-color on seeing old transparency It will be available in 5.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. This appears to be fixed in the latest master 5.0.0.0.alpha1+. Thank you. *** Bug 90819 has been marked as a duplicate of this bug. *** Migrating Whiteboard tags to Keywords: (bibisected) [NinjaEdit] |