| Summary: | core/sw/source/core/text/txtftn.cxx:530: bad ? : | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | dcb314 |
| Component: | Base | Assignee: | Julien Nabet <serval2412> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | iplaw67, lionel, serval2412 |
| Priority: | medium | ||
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| URL: | http://dev-builds.libreoffice.org/cppcheck_reports/master/1841.html#line-530 | ||
| Whiteboard: | |||
| Crash report or crash signature: | Regression By: | ||
@dcb314 : stuff like this is usually best discussed on the libreoffice irc channel. Looking at git history, it's been like this since http://cgit.freedesktop.org/libreoffice/core/commit/?id=887b3a35628b349e7934f2ae7c220a1cc17c3e63 Caolan fixed a similar place here: http://cgit.freedesktop.org/libreoffice/core/commit/?id=8f9bc93ba3299efbd8ad181481e6e2e87df7c066 I'll push a patch for this remaining part. Fixed in master with http://cgit.freedesktop.org/libreoffice/core/commit/?id=ce1365ec147a33a07df5bdc53796180d84b9d9e5 I don't think it worths it to cherry-pick this on 4.4 or even less in 4.3 since there's no impact. |
[core/sw/source/core/text/txtftn.cxx:530]: (style) Same expression in both branches of ternary operator. OSL_ENSURE( bEndn ? !SwFtnBossFrm::FindFtn( this, pFtn ) : !SwFtnBossFrm::FindFtn( this, pFtn ), "SwTxtFrm::RemoveFtn: can't get off that footnote" );