| Summary: | FILEOPEN: DOCX - Incorrect text highlight color in table header | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Janusz <jh> |
| Component: | Writer | Assignee: | Justin L <jluth> |
| Status: | VERIFIED FIXED | ||
| Severity: | normal | CC: | ilmari.lauhakangas, iplaw67, jluth, jmadero.dev, philipz85, xiscofauli |
| Priority: | medium | Keywords: | filter:docx, preBibisect, regression |
| Version: | 3.5.0 release | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
https://bugs.documentfoundation.org/show_bug.cgi?id=91292 https://bugs.documentfoundation.org/show_bug.cgi?id=121111 https://bugs.documentfoundation.org/show_bug.cgi?id=137683 |
||
| Whiteboard: | target:6.2.0 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 104444 | ||
| Attachments: | example of the bug | ||
Opening DOCX document with table, where there is a header background color set as grey, text formatted as auto - Libre Office present text on white background (should be gray or transparent). This is only related to a document in docx format, exporting same document from word to old doc format, then opening it in libre office shows proper formatting Hello Janusz, Thank you for submitting the bug. I can confirm that the bug is available in 3.5.7, 4.0.6 and master on Linux. Its a regression as it doesnt happen in 3.3.0. Version: 5.0.0.0.alpha1+ Build ID: badec7478035008f514e0976a94438fe2e32dc40 TinderBox: Linux-rpm_deb-x86@45-TDF, Branch:master, Time: 2015-04-22_00:50:58 Version: 5.0.0.0.alpha1+ Build ID: 950055bcb06c8edcd9062c71184f02bf8e0604e6 Locale : fr_ Confirming Apple Pages 5.5.2 : displays the docx table header text correctly Word 15.8.0 (Preview) : displays the docx table header text correctly Confirming Migrating Whiteboard tags to Keywords: (bibisectRequest) [NinjaEdit] Happened before bibisect is available (before 3.5.beta0) Changing version to 3.5.0 as mentioned in comment 5 and adding keyword 'preBibisect' Repro. See Character formatting - Highlight. It is white instead of no fill. Arch Linux 64-bit Version: 6.1.0.0.alpha0+ Build ID: a7bb853b348cc5ebe4ccdb07d1ee0fc38de21e7a CPU threads: 8; OS: Linux 4.15; UI render: default; VCL: kde4; Locale: fi-FI (fi_FI.UTF-8); Calc: group Built on March 14th 2018 The white character background comes from the Normal style w:fill.
<w:style w:type="paragraph" w:default="1" w:styleId="Normal">
<w:color w:val="000000"/><w:shd w:val="clear" w:color="auto" w:fill="FFFFFF"/>
The cells are trying to override it with w:fill="auto", but AutoFillColor is being ignored.
else if ((nWW8BrushStyle || !m_bAutoFillColor))
{
pPropertyMap->Insert( m_OutputFormat == Form ? PROP_BACK_COLOR
: PROP_CHAR_BACK_COLOR, uno::makeAny( nApplyColor ));
proposed fix at https://gerrit.libreoffice.org/59313 (In reply to Justin L from comment #9) > proposed fix at https://gerrit.libreoffice.org/59313 Depends on additional patch to bug 91292 Justin Luth committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=7d9e9ecd5bb5d5abec338c2ceb61ad623d2ac5cb tdf#90906 writerfilter: Allow COL_AUTO to override non-auto It will be available in 6.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. This could be backported if desired, since the patch it depends on was backported. But I'm not planning on backporting since it seems like a rare need. Thanks, verified! Arch Linux 64-bit Version: 6.2.0.0.alpha0+ Build ID: 3c86ffd8ded628e6f2b4187948a1b1056f6a0f56 CPU threads: 8; OS: Linux 4.18; UI render: default; VCL: gtk3_kde5; Locale: fi-FI (fi_FI.UTF-8); Calc: threaded Built on September 5th 2018 |
Created attachment 115153 [details] example of the bug