| Summary: | During merge, don't ask to move cells if they are empty | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | myplace4yourspam |
| Component: | Calc | Assignee: | Laurent Balland <jumbo4444> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | fdbugs, h3734236, ilmari.lauhakangas, jumbo4444 |
| Priority: | medium | ||
| Version: | Inherited From OOo | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | target:5.3.0 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 108320 | ||
| Attachments: | screencapture of bug | ||
Reproduced, but not with 3.5.0!! Win 7 Pro 64-bit Version: 5.0.0.0.alpha1+ (x64) Build ID: f0edb677f09ad338e22ac3b5d91497b4479e0b3c TinderBox: Win-x86_64@42, Branch:master, Time: 2015-04-27_01:54:20 Locale: fi_FI Ubuntu 15.04 64-bit Version: 4.4.2.2 Build ID: 40m0(Build:2) Locale: en_US LibreOffice 3.5.0rc3 Build ID: 7e68ba2-a744ebf-1f241b7-c506db1-7d53735 I can reproduce this back to OOo 3.3.0 @Beluga: Also reproduces for me on libreoffice-3.5.0rc3, could you re-check? Thanks -> Version: Inherited from OOo (In reply to Matthew Francis from comment #2) > I can reproduce this back to OOo 3.3.0 > > @Beluga: Also reproduces for me on libreoffice-3.5.0rc3, could you re-check? > Thanks > > -> Version: Inherited from OOo unable to reproduce on Win 7 LibreOffice 3.5.0rc3 Käännöksen ID: 7e68ba2-a744ebf-1f241b7-c506db1-7d53735 The bug is simpler to reproduce: 1. Enter value in A2 2. Select A1:B1 3. Click the "Merge and Center Cells" toolbar button Actual behavior: A dialog asks "Should the contents of the hidden cells be moved into the first cell?" Expected behavior: As B1 is empty, there is nothing to move, so there should not be any question Conditions to reproduce: - select only 1 line - a value is present in the first column of the next line of the selection Entry point: http://opengrok.libreoffice.org/xref/core/sc/source/ui/view/viewfun2.cxx#MergeCells Test here fails: http://opengrok.libreoffice.org/xref/core/sc/source/ui/view/viewfun2.cxx#1066 Laurent Balland-Poirier committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=0baeea95f38a5cdb19936290c69d33541274ad41 tdf#90943 Don't ask to move cells if they are empty It will be available in 5.3.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |
Created attachment 115193 [details] screencapture of bug Steps to reproduce bug... 1. Enter any text into cell A1 2. Right click row 1 and select "Insert Rows Above" 3. Select cells A1 to B1 4. Click the "Merge and Center Cells" toolbar button The aforementioned procedure results in a dialog which displays the following... "Should the contents of the hidden cells be moved into the first cell?" Selecting B1 to C1 and merging works as expected. I suspect this has something to do with the insert new row command carrying information about the row below it since the dialog only appears when merging cells above cells that contain data.