| Summary: | cleanup weirdo function prototypes ... | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Michael Meeks <michael.meeks> |
| Component: | Chart | Assignee: | Jens Carl <j.carl43> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | mentoring, robinson.libreoffice |
| Priority: | medium | Keywords: | difficultyBeginner, easyHack, skillCpp, topicCleanup |
| Version: | 4.4.3.2 release | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | ToBeReviewed | ||
| Crash report or crash signature: | Regression By: | ||
To identify these lines I wrote:
git grep -n -E -e '^::[a-zA-Z0-9_]*\(' -- '*.cxx'
(It's pretty basic since git-grep doesn't support multiline patterns and finding function prototype with pattern is pretty hard.)
I found like 25 lines with that and will change them according to your example.
Jens Carl committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=5bf6fecde772d1fb35645fe217e6fe3b5b5ac918 tdf#91054: cleanup weirdo function prototypes It will be available in 5.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. I sent following patch for this bug; https://gerrit.libreoffice.org/#/c/19328/ kerem committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=98528be2fe1160d45f62222193da482f5bb06d00 tdf#91054 cleanup weirdo function prototypes It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Migrating Whiteboard tags to Keywords: (EasyHack DifficultyBeginner SkillCpp TopicCleanup ) [NinjaEdit] I sent following patch for this bug : https://gerrit.libreoffice.org/#/c/21990/ irem committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=e1cd15fbac8727627c06e7a1e7c00691c66b0a11 tdf#91054 cleanup weirdo function prototypes It will be available in 5.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. JanI is default CC for Easy Hacks (Add Jan; remove LibreOffice Dev List from CC) [NinjaEdit] If there are other places, we need a new code pointer. |
If you poke at (at least) chart2/source/tools/LifeTime.cxx you can see the most amazing function signatures like this: bool CloseableLifeTimeManager ::g_close_startTryClose(bool bDeliverOwnership) throw ( uno::Exception ) { There is no real consensus on the 'right' way to do function prototypes, so don't go wild changing everything; but the above looks really wrong & unusual to me =) it'd be good to find instances of this particular oddness & change them to (perhaps) bool CloseableLifeTimeManager::g_close_startTryClose(bool bDeliverOwnership) throw ( uno::Exception ) which at least looks like a method ;-) Thanks !