Bug 91174

Summary: deleting several cells of formulas Crashes LibO when attempting to recalculate.
Product: LibreOffice Reporter: S.Andreason <sandreas41>
Component: CalcAssignee: Not Assigned <libreoffice-bugs>
Status: CLOSED WORKSFORME    
Severity: major CC: fdbugs, jmadero.dev, serval2412
Priority: high Keywords: bibisected, bisected, regression
Version: 4.4.2.2 release   
Hardware: All   
OS: Linux (All)   
Whiteboard:
Crash report or crash signature: Regression By:
Attachments: ledger for testing two bugs

Description S.Andreason 2015-05-08 18:24:11 UTC
Created attachment 115459 [details]
ledger for testing two bugs

When deleting several cells of formulas at one action, Delete cell contents, then LibO crashes.

I'm running:
Version: 4.4.2.2
Build ID: c4c7d32d0d49397cad38d62472b0bc8acff48dd6
Locale: C_
Linux x86

Steps to reproduce.
Load the sample spreadsheet test-ledger.ods
Select BB9:BS9 either with mouse or entering into name box.

Multiple paths and results:
If Edit.Delete contents, then it works correctly.
If press [Delete] key, which is mapped to the same action, except without the dialog box, then it crashes immediately.
If I use the right mouse to Delete contents, after accepting the dialog box, it instead takes 2-3 seconds before crashing.
If I first remove lines of sum totals A503:AMJ516, thus removing the number of cells needing to be recalculated, then when repeating the test, LibO does instead hang in an infinite loop.
If I first delete rows 27:516, then it works correctly (pressing [Delete]).

I did notice bugs 90689 and 90694 first, but despite the similarities in title and description, I was not able to reproduce those two samples provided. Thus I'm filing this bug under it's own number.
Comment 1 Joel Madero 2015-05-08 18:42:30 UTC
Ubuntu 15.04 x64
LibreOffice 4.4.2.2
LibreOffice 3.3 (inherited from OOo)

> 
> Steps to reproduce.
> Load the sample spreadsheet test-ledger.ods
> Select BB9:BS9 either with mouse or entering into name box.
> 
> Multiple paths and results:
> If Edit.Delete contents, then it works correctly.

LibreOffice 4.4.2.2 -- crash
LibreOffice 3.3 (inherited from OOo) -- no crash

> If press [Delete] key, which is mapped to the same action, except without
> the dialog box, then it crashes immediately.

LibreOffice 4.4.2.2 --crash (faster than above crash)
LibreOffice 3.3 (inherited from OOo) -- no crash


> If I use the right mouse to Delete contents, after accepting the dialog box,
> it instead takes 2-3 seconds before crashing.

LibreOffice 4.4.2.2 -- crash (immediately)
LibreOffice 3.3 (inherited from OOo) -- no crash


> If I first remove lines of sum totals A503:AMJ516, thus removing the number
> of cells needing to be recalculated, then when repeating the test, LibO does
> instead hang in an infinite loop.

*I'm not repeating each test above - just highlighted the relevant cells and pushed delete key.

LibreOffice 4.4.2.2 - loop
LibreOffice 3.3 (inherited from OOo) -- no crash

I'm not 100% sure that these are all the same issue (especially the last one) but I'm going to push as NEW and mark as a regression.

@S. Anreason - I'm changing this to Major instead of Critical. If you can create a simpler test case that shows that it will affect others more than we can push it back to Critical. Critical is supposed to be kept for crashes that will affect the majority of our users - this is a complex (kind of) sheet so given that, less likely to impact the wider community enough to warrant critical status.


Going to try to bibisect now.
Comment 2 Joel Madero 2015-05-08 18:43:25 UTC
Just checked LibreOffice 5 and it's already fixed. Going to check LibreOffice 4.4 daily to see if it's fixed there also.
Comment 3 Joel Madero 2015-05-08 19:24:49 UTC
Bad news - still an issue in 4.4 daily so something in 5 fixed the problem but was not backported....


++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ d12d1a450eb7599eb60ba605ce7a7e8b12bcb744 is the first bad commit
commit d12d1a450eb7599eb60ba605ce7a7e8b12bcb744
Author: Matthew Francis <mjay.francis@gmail.com>
Date:   Sun Mar 15 06:07:23 2015 +0800

    source-hash-5ef856e975d7c0396984d588a43fd1a7c7085c55
    
    (Bibisect: Skipped preceding irrelevant commit(s) b2efe90c07baa45d2ee7e13138dd306a29738473)
    
    commit 5ef856e975d7c0396984d588a43fd1a7c7085c55
    Author:     Kohei Yoshida <kohei.yoshida@collabora.com>
    AuthorDate: Tue Nov 18 21:03:05 2014 -0500
    Commit:     Kohei Yoshida <kohei.yoshida@collabora.com>
    CommitDate: Tue Nov 18 21:03:50 2014 -0500
    
        Use group area listeners during ODS import.
    
        Change-Id: Id01f9021dda7f33255f8206174cd730507ab55ad

:040000 040000 126e010c62ce770ece406648bd72b0d2505c593f e7bee6d7439acbe7be3fd506baefed81c493b191 M	opt


# bad: [cf6ea17155fabb2a120ba07c150735591ac861d7] source-hash-3f94c9e9ddfd807b449f3bb9b232cf2041fa12d2
# good: [fc71ac001f16209654d15ef8c1c4018aa55769f5] source-hash-c15927f20d4727c3b8de68497b6949e72f9e6e9e
git bisect start 'latest' 'oldest'
# good: [8cf60cc706948588e2f33a6d98b7c55d454e362a] source-hash-f340f0454627939f1830826fb5cc53a90e6c62a4
git bisect good 8cf60cc706948588e2f33a6d98b7c55d454e362a
# good: [7beddf3808dadd525d7e55c00a5a90a2b44c23d3] source-hash-2f10386ce577f52e139aa23d41bc787d8e0b4d59
git bisect good 7beddf3808dadd525d7e55c00a5a90a2b44c23d3
# good: [fb3ec529b3f37f0c7eab2e9b7a9cc695c0f27676] source-hash-0516d123f53917d1833c7e8a8c528a619c71a0af
git bisect good fb3ec529b3f37f0c7eab2e9b7a9cc695c0f27676
# good: [47a64818ddfe63bbb8e6448fcc476f55996d61b1] source-hash-d12efada389643ab0e13a280246d14caed273029
git bisect good 47a64818ddfe63bbb8e6448fcc476f55996d61b1
# good: [8f2027699192b7f2aaf83f95a02c817f2e0c8d50] source-hash-eb6d27321d2d5f9d069c4a3cbcc9bc6e5b4c98ab
git bisect good 8f2027699192b7f2aaf83f95a02c817f2e0c8d50
# good: [a318eefc5f56a820803027a525c255451cd603bd] source-hash-537befbb2fd5f1587f7c9cd8c55498d29b713770
git bisect good a318eefc5f56a820803027a525c255451cd603bd
# bad: [ae924ef4ddc9d3c4a941fa9c444f9712c59721cf] source-hash-7fe2a3fd370049d7599c301d2af71ca61fec1431
git bisect bad ae924ef4ddc9d3c4a941fa9c444f9712c59721cf
# bad: [4215aa7df7b2f632c2bcf6abc2f49388fc510042] source-hash-db222b74f1482870aac76d51646215d756901b8d
git bisect bad 4215aa7df7b2f632c2bcf6abc2f49388fc510042
# bad: [6ca58fb62944a6ef674e4630740673971334f424] source-hash-1b9aaba0bfe8bc0872e7ea9f9aef5961e4b52f7c
git bisect bad 6ca58fb62944a6ef674e4630740673971334f424
# good: [2fbc206d20f554cf0d4dc88e1a14ccf640073d46] source-hash-fa6a174b50747e6f6c83d0cd882ce0bd0886930b
git bisect good 2fbc206d20f554cf0d4dc88e1a14ccf640073d46
# good: [91a743cfeb5a2058613fb4a839b6914642cd169b] source-hash-661dc51a8a1951419a3a9def39d968e718f57b72
git bisect good 91a743cfeb5a2058613fb4a839b6914642cd169b
# good: [7622d1f976d615c080e32535929084a55b93b193] source-hash-b9b0ac0057bba4b02534493de08f3fce0c784be8
git bisect good 7622d1f976d615c080e32535929084a55b93b193
# bad: [d12d1a450eb7599eb60ba605ce7a7e8b12bcb744] source-hash-5ef856e975d7c0396984d588a43fd1a7c7085c55
git bisect bad d12d1a450eb7599eb60ba605ce7a7e8b12bcb744
# good: [ad806e9b6fa58c2589859cb3c55511235f2c534f] source-hash-1296f9063203a3f9488689136b833568c183edab
git bisect good ad806e9b6fa58c2589859cb3c55511235f2c534f
# first bad commit: [d12d1a450eb7599eb60ba605ce7a7e8b12bcb744] source-hash-5ef856e975d7c0396984d588a43fd1a7c7085c55
Comment 4 Robinson Tryon (qubit) 2015-12-13 11:13:14 UTC
Migrating Whiteboard tags to Keywords: (bibisected)
[NinjaEdit]
Comment 5 Julien Nabet 2016-04-29 10:49:49 UTC
Now 4.X is EOL, let's put this one to WFM.
Comment 6 S.Andreason 2016-04-29 15:46:12 UTC
Revisiting this test in 4.4.7.2 and I find it is fixed. Thanks.
Comment 7 Julien Nabet 2016-04-29 15:47:47 UTC
Thank you for your feedback, let's put this VERIFIED.
Comment 8 Julien Nabet 2016-04-29 15:48:01 UTC
...and close it