| Summary: | PPT import: slide titles are misplaced | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Andras Timar <timar74> |
| Component: | Impress | Assignee: | Mike Kaganski <mikekaganski> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | Armin.Le.Grand, michael.meeks, stgohi-lobugs, thb, timar74, xiscofauli |
| Priority: | medium | Keywords: | bibisected, bisected, regression |
| Version: | 4.1 all versions | ||
| Hardware: | Other | ||
| OS: | All | ||
| See Also: | https://bugs.documentfoundation.org/show_bug.cgi?id=41245 | ||
| Whiteboard: | target:5.2.0 target:5.1.4 target:5.3.0 target:5.2.5 | ||
| Crash report or crash signature: | Regression By: | ||
| Attachments: |
bugdoc (PPT)
Test file used to check patch for regressions Improved test file with reference screenshots from MS PowerPoint autofit test document Two PDFs made from attachment 123726, with LO 5.1.1.3 and with LODev with patch applied |
||
|
Description
Andras Timar
2015-08-04 19:33:14 UTC
Saving copy of this file as pptx using MS PowerPoint and opening it with LO, everything shows right. The difference is that in pptx version, the "Full width" checkbox is set, and naturally, the text anchor is set to middle-bottom; while in ppt version, the text anchor point is in the left-bottom corner (select title border, then menu "Format->Text", first tab). Setting the flag makes everything right. By the way, the same applies to Bug 41245 and AOO#119885. So, in essence, it seems that ppt version fails to set the "Full width" flag. Submitted patch to gerrit: https://gerrit.libreoffice.org/18895 Migrating Whiteboard tags to Keywords: (bibisected) Reproducible with LO 5.1.0.2, Win 8.1 It is fine in MSO. Created attachment 122983 [details]
Test file used to check patch for regressions
This PPT (created with MS PowerPoint 2013) contains objects (simple ellipses and clouds) with differently aligned text.
Created attachment 123223 [details]
Improved test file with reference screenshots from MS PowerPoint
Here the colors are changed to be more readable; each conbination is explained.
Mike Kaganski committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=5ca1f04976930c6fd656ebf89d667c80e2466897 tdf#93124: Fix incorrect text fit in imported PPT It will be available in 5.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Created attachment 123726 [details]
autofit test document
Sadly, this broke the autofit feature. A more minimal fix would be better.
Thorsten Behrens committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=3445fb9326fb632498cf2123aa1213be40e789c1 Revert "tdf#93124: Fix incorrect text fit in imported PPT" It will be available in 5.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. (In reply to Thorsten Behrens (CIB) from comment #8) > Created attachment 123726 [details] > autofit test document > > Sadly, this broke the autofit feature. A more minimal fix would be better. Could you please describe what's wrong with the autofit? I don't see differences with the patch comparative to vanilla 5.1.1.3... Created attachment 123727 [details] Two PDFs made from attachment 123726 [details], with LO 5.1.1.3 and with LODev with patch applied Maybe there's a problem with autofit test file? (In reply to Mike Kaganski from comment #10) > Could you please describe what's wrong with the autofit? > I don't see differences with the patch comparative to vanilla 5.1.1.3... > Oh - sorry, that might not have been obvious indeed. Type some text in the box containing 'This is a text', until the space is full. Without the patch, the text auto-sizes. With the patch applied, it simply overflows the slide downwards. (In reply to Thorsten Behrens (CIB) from comment #12) > (In reply to Mike Kaganski from comment #10) > > Could you please describe what's wrong with the autofit? > > I don't see differences with the patch comparative to vanilla 5.1.1.3... > > > Oh - sorry, that might not have been obvious indeed. Type some text in > the box containing 'This is a text', until the space is full. Without > the patch, the text auto-sizes. With the patch applied, it simply > overflows the slide downwards. I opened autofit.ppt (attachment 123727 [details]) in PowerPoint 2010. The text box did not have the autofit property. I typed some text in the box until the space was full. And it overflowed the text box. This is not a good bug document (if we accept PowerPoint 2010 as the reference renderer). (In reply to Andras Timar from comment #13) > I opened autofit.ppt (attachment 123727 [details]) in PowerPoint 2010. The > text box did not have the autofit property. I typed some text in the box > until the space was full. And it overflowed the text box. This is not a good > bug document (if we accept PowerPoint 2010 as the reference renderer). > Maybe, sure - though I'm pretty sure the test document is from an older PPT version. But that's somewhat beside the point - looking at https://gerrit.libreoffice.org/#/c/18895/7/filter/source/msfilter/svdfppt.cxx , is there _any_ input that would enable autofit in that filter? The patch is pretty intrusive, why not simply fix the bug at hand? > is there _any_ input that would enable autofit in that filter?
I believe Mike K is working on a unit test for auto-fit import with two text boxes one fitting, one not etc. - and then we'll avoid this question in future.
This particular chunk of code seems to go in and out like a yoyo across several commits.
We have increasingly competent tests, and test-cases here; I would prefer to move forward in the direction of ever more tests. If we find subsequent problems - we can add more fixes, with more tests =)
Mike Kaganski committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=940b21a87cffffca0985c33e9ebb78ddf3aa0c3b tdf#93124: Fix incorrect text fit in imported PPT - take two It will be available in 5.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Mike Kaganski committed a patch related to this issue. It has been pushed to "libreoffice-5-1": http://cgit.freedesktop.org/libreoffice/core/commit/?id=ac2732bdc63fa687909fdf03e2a91081003f109e&h=libreoffice-5-1 tdf#93124: Fix incorrect text fit in imported PPT - take two It will be available in 5.1.4. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Tor Lillqvist committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=9c07735a0160864c949ac27de1821d6967181516 tdf#93124: The arbitrary number 100 seems to be too high, let's try 50 It will be available in 5.3.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Hi, Is this bug fixed? If so, could you please close it as RESOLVED FIXED? Regards Tor Lillqvist committed a patch related to this issue. It has been pushed to "libreoffice-5-2": http://cgit.freedesktop.org/libreoffice/core/commit/?id=8fdb960a4fca24ae4ef3e9706218ca00cb7f4fd0&h=libreoffice-5-2 tdf#93124: The arbitrary number 100 seems to be too high, let's try 50 It will be available in 5.2.5. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |