Bug 93581

Summary: Editing and Formatting of "copy row" operation
Product: LibreOffice Reporter: David <dcramptond>
Component: CalcAssignee: Not Assigned <libreoffice-bugs>
Status: RESOLVED WORKSFORME    
Severity: minor CC: aron.budea, jmadero.dev, kohei, miguelangelrv, raal
Priority: medium Keywords: bibisected, bisected, regression
Version: 4.4.0.0.beta1   
Hardware: All   
OS: All   
Whiteboard:
Crash report or crash signature: Regression By:

Description David 2015-08-21 18:55:28 UTC 
Row Height fails to be included in a "copy row" operation. This is a new moderately annoying GUI big in 4.4.5.2.  What I describe below has worked as I expected in all earlier versions I have used.

Details:

Default row height is 0.18"

To create visual vertical separations in my spreadsheet I create rows of height 0.09" with borders on all 4 sides, color red.

I have heretofore been able to create a new such separating row by selecting a previous (already existing) row; do "Shift + Space" to expand selection to entire row. Ctrl + C: copy.  Move selected cell to my new separation row. Shift + Space to expand to entire row. Ctrl + V: paste.

Expected result: the row will carry all the formatting (borders) and will shrink to the .09" height.

Actual result: the formatting copies OK but the row height remains unchanged.

Works the same if the height of the separator row is greater than default; say 0.24". The height does not come along with the copy/paste.

Similar to existing other row height bugs I read, such as 55433. My report is succinctly on the "copy row" failure to include row height.
Comment 1 Joel Madero 2015-08-21 20:08:02 UTC 
Please attach a *simple* sample document. setting to NEEDINFO, once you attach a document please set to UNCONFIRMED. In the future when reporting bugs please know that sample documents are almost always required if at all possible - our team is too small to be duplicating sample documents when we have tens of millions of users :)


Thanks!
Comment 2 m_a_riosv 2015-08-21 23:34:37 UTC 
Hi @David, thanks for reporting.

Steps:
In A1: a
Change the size of row 1
Click on the row 1 number to select the row
Copy with "right-click copy" or [Ctrl+C]
In any other row, select the row clicking on the number or go to the cell A.
Paste with "right-clck paste" or [Ctrl+V]

Up to version Versión: 4.3.7.2 Id. de compilación: 8a35821d8636a03b8bf4e15b48f59794652c68ba
the pasted row receive the height of the copied row.

From
Version: 4.4.0.0.beta1+
Build ID: 95b0f165e30a7dc99a76925c613a51992c85ec54
TinderBox: Win-x86@42, Branch:libreoffice-4-4, Time: 2015-01-09_19:02:36
up to masters,
it's reproducible.

Works well for columns width.
Comment 3 Joel Madero 2015-08-21 23:39:34 UTC 
Minor - slows down but does not prevent high quality work;
Medium - bumped up from low because it's a regression
Comment 4 m_a_riosv 2015-08-22 00:24:38 UTC 
Hi David,
for me the best workaround is in a cell out data zone, format:
with a text size or 
a top/bottom cell spacing to contents (Borders tab),
that better fits your wanted height.

I'm used to do in that way, because it has the advantage that it's possible to do an "Optimal row height" for the whole sheet, without losing the row's height.
Comment 5 raal 2015-12-02 21:08:17 UTC 
This seems to have begun at the below commit.
Adding Cc: to Kohei Yoshida ; Could you possibly take a look at this one?
Thanks
 41597bab6e54abeafeca5130c60a064bf7b7f72d is the first bad commit
commit 41597bab6e54abeafeca5130c60a064bf7b7f72d
Author: Matthew Francis <mjay.francis@gmail.com>
Date:   Sun Mar 15 06:03:44 2015 +0800

    source-hash-ff5aad0a26aac46a3a540ac6ed2b7eca4a8cd23d
    
    commit ff5aad0a26aac46a3a540ac6ed2b7eca4a8cd23d
    Author:     Kohei Yoshida <kohei.yoshida@collabora.com>
    AuthorDate: Mon Nov 10 18:45:21 2014 -0500
    Commit:     Kohei Yoshida <kohei.yoshida@collabora.com>
    CommitDate: Tue Nov 18 08:31:53 2014 -0500
    
        Speed up pasting of single row onto multiple destination rows.
    
        This is an extension of the earlier paste optimization of a single cell
        across multiple destination cells.
    
        Change-Id: I3a60300d3d0e11420d997bea8f7f540e948f56cc
Comment 6 Robinson Tryon (qubit) 2015-12-13 11:13:14 UTC Comment hidden (obsolete)
Comment 7 Aron Budea 2016-09-11 03:28:09 UTC 
Seems fixed in 5.2.1.2.
Not fixed in 5.1.5.2.

Since it's a minor issue, and there's only one more update planned to 5.1 version, I'd say not bother with backporting.