| Summary: | FILESAVE: DOCX - Margins not preserve | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Yousuf Philips (jay) (retired) <philipz85> |
| Component: | Writer | Assignee: | Justin L <jluth> |
| Status: | VERIFIED FIXED | ||
| Severity: | normal | CC: | aron.budea, buzea.bogdan, jluth, jmadero.dev |
| Priority: | medium | Keywords: | filter:docx, notBibisectable, regression |
| Version: | 4.2.0.4 release | ||
| Hardware: | Other | ||
| OS: | All | ||
| See Also: |
https://bugs.documentfoundation.org/show_bug.cgi?id=83227 https://bugs.documentfoundation.org/show_bug.cgi?id=112118 |
||
| Whiteboard: | target:6.2.0 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 104444 | ||
| Attachments: |
bug confirmed, screenshot
0pgMar.odt: minimal reproducer test when saving to .doc or .docx How it looks on 6.2 |
||
|
Description
Yousuf Philips (jay) (retired)
2015-09-08 07:07:00 UTC
Resaved as new docx file. Problem confirmed on OSX 10.10.5 LO Version: 5.1.0.0.alpha1+ Build ID: 50f2c712c46c66264279ab3b61888e491a4d8dca TinderBox: MacOSX-x86_64@49-TDF, Branch:master, Time: 2015-09-04_04:59:19 Locale: de-DE (de.UTF-8) Attaching screenshot. Created attachment 118515 [details]
bug confirmed, screenshot
Migrating Whiteboard tags to Keywords: (bibisectRequest) [NinjaEdit] Unfortunately this bug isn't bibisectable because of a separate bug that happens in the bibisect that prevents saving the file at all (infinite loop during save as). Marking as such. Michael Stahl committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=549130ab5d9616f7eb5504db31546b386737ccb2 fdo#94009: harfbuzz: don't export symbols from VCL It will be available in 5.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Michael Stahl committed a patch related to this issue. It has been pushed to "libreoffice-5-1": http://cgit.freedesktop.org/libreoffice/core/commit/?id=37f7d9ee1d9399c5aa5e9975579f319b1fa045dc&h=libreoffice-5-1 fdo#94009: harfbuzz: don't export symbols from VCL It will be available in 5.1.2. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Michael Stahl committed a patch related to this issue. It has been pushed to "libreoffice-5-0": http://cgit.freedesktop.org/libreoffice/core/commit/?id=395995f03dd640aee28767f6d920901d91dd3bee&h=libreoffice-5-0 fdo#94009: harfbuzz: don't export symbols from VCL It will be available in 5.0.6. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Michael Stahl committed a patch related to this issue. It has been pushed to "libreoffice-5-1-1": http://cgit.freedesktop.org/libreoffice/core/commit/?id=548e0bf3d134049b8079ae33a019ef8805c96b47&h=libreoffice-5-1-1 fdo#94009: harfbuzz: don't export symbols from VCL It will be available in 5.1.1. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Hm, that patch is not related to this bug… oh indeed, that is apparently a bug in the bugzilla script, actually the commits in comment #5 should be disregarded since they were about the harfbuzz bug filed at https://bugs.freedesktop.org/show_bug.cgi?id=94009 guess i should have filed a bug in TDF bugzilla for it but took the lazy route This makes heavy use of continuous section breaks which are deadly for compatibility and page styles. (Page 2 starts with section 6.) Created attachment 144642 [details]
0pgMar.odt: minimal reproducer test when saving to .doc or .docx
I think the problem is in SW code handling sections, because writerfilter passes the top margin property all the way to unostyles.cxx. Likely, because everything is a default value, the property isn't being SET, and so is never exported.
The problem is avoidable by forcing a non-default value in PropertyMap.cxx
-Insert( PROP_TOP_MARGIN, uno::makeAny( std::max<sal_Int32>(nTopMargin, 0) ) );
+Insert( PROP_TOP_MARGIN, uno::makeAny( std::max<sal_Int32>(nTopMargin, 1) ) );
OK. Not at all related to SW internals. Simply export code ignoring defaults. gerrit.libreoffice.org/59967 tdf#94009 ww8export: always export section margins Justin Luth committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=efd316b6171b9e1827c5e34ddb12658f48268e24 tdf#94009 ww8export: always export section margins It will be available in 6.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Created attachment 144900 [details] How it looks on 6.2 This is how it looks on 6.2 after save as... As speaking about margins this are zero, it's perfect. But the document aspect changed. Version: 6.2.0.0.alpha0+ Build ID: 9a9b81c7212fa6a6762246593acf3f1950677a22 CPU threads: 4; OS: Linux 4.15; UI render: GL; VCL: gtk2; TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2018-09-08_00:00:43 Locale: ro-RO (ro_RO.UTF-8); Calc: threaded |