Bug 95622

Summary:	About dialog slow to show up since version 5.0 because of SVG images
Product:	LibreOffice	Reporter:	Thomas <thomas-lange2>
Component:	LibreOffice	Assignee:	Not Assigned <libreoffice-bugs>
Status:	RESOLVED FIXED
Severity:	trivial	CC:	aron.budea, barta, cloph, jbfaure, lo_bugs, stgohi-lobugs, tbertels+bugzilla, telesto, xiscofauli
Priority:	medium	Keywords:	bibisected, bisected, perf, regression
Version:	5.0.0.5 release
Hardware:	All
OS:	All
See Also:	https://bugs.documentfoundation.org/show_bug.cgi?id=129224
Whiteboard:
Crash report or crash signature:		Regression By:
Bug Depends on:
Bug Blocks:	112231
Attachments:	Optimized about dialog SVG file (fully vectorized)

Description Thomas 2015-11-05 22:28:33 UTC

User-Agent:       Mozilla/5.0 (X11; Linux x86_64; rv:42.0) Gecko/20100101 Firefox/42.0
Build Identifier: LibreOffice 5.0.3.2

It takes nearly three seconds until the about dialog in any LibreOffice component shows up. This seems slow to me, especially for a computer with a SSD. 

The problem is trivial but I decided to report it anyway. It occurs since version 5.0.

Reproducible: Always

Steps to Reproduce:
1. Start any LibreOffice component, e.g. Writer
2. Click "Help"
3. Click "About LibreOffice"
Actual Results:  
2-3 seconds no response until the dialog is shown

Expected Results:  
Instant showing of the about dialog

Locale: de
OS: Arch Linux
OS is 64bit: yes


Reset User Profile?Yes

Comment 1 tommy27 2015-11-06 11:27:51 UTC

it takes 1.5 seconds under Win7x64 using LibO 5.0.3.1 and recent 5.1.0.0 daily builds

Comment 2 A (Andy) 2015-11-06 19:08:12 UTC

For me reproducible with LO 5.0.3.2, Win 8.1.

It takes around 2 to 2.5 seconds until the About LibreOffice dialog box is opened.

Comment 3 tommy27 2015-11-07 06:05:21 UTC

(In reply to tommy27 from comment #1)
> it takes 1.5 seconds under Win7x64 using LibO 5.0.3.1 and recent 5.1.0.0
> daily builds

it shows up instantly with LibO 4.4.5 so that's a regression and needs bibisecting

Comment 4 Robinson Tryon (qubit) 2015-12-14 05:32:44 UTC Comment hidden (obsolete)

Migrating Whiteboard tags to Keywords: (bibisectRequest)
[NinjaEdit]

Comment 5 Terrence Enger 2015-12-19 04:07:53 UTC Comment hidden (bibisection)

Working in the daily dbgutil repository, I see from `git bisect good` ...

    e229217b7da6f5d9225edffd69287f33299c8684 is the first bad commit
    commit e229217b7da6f5d9225edffd69287f33299c8684
    Author: Miklos Vajna <vmiklos@collabora.co.uk>
    Date:   Sat Jul 25 05:39:10 2015 +0200

        2015-07-25: source-hash-fe88fe6f828597fe2645a20c1a07716216a810c3

    :100644 100644 e47729709af478c8bdef5554255c16d44cedc8f5 d8489393443e2bae309b1803ab7dca1228e93ff1 M	build-info.txt
    :040000 040000 8b5dfb113b7f678743a27d4757f6a49316d05d90 c7242ffd226363d7282c112b66a265d1a757e9f5 M	opt

and from `git bisect log` ...

    # bad: [c5625a3e1014766a488ca42e986be5dd3efbf051] 2015-11-24: source-hash-e5b3ec9683e4c5761633a1a3c4819a039e796b01
    # good: [2b392af9c8f54629e3a3a98a8c92fa5af1c6722f] 2015-05-20: source-hash-90e2dabb8d0bb5382234be776c2ad0e2d5d9e224
    git bisect start 'c5625a3' '2b392af'
    # bad: [a8d19eafb9e195a85359dd8cdc5c46c38295caa0] 2015-08-22: source-hash-79fb61efb847405fa47235002b52ee8efad5e339
    git bisect bad a8d19eafb9e195a85359dd8cdc5c46c38295caa0
    # good: [c9abefa2facd9d5f2989bbc2138e55970e60c4cd] 2015-07-06: source-hash-64385c7555c6bbb089f3ab8b2a5b623cadd6ee7d
    git bisect good c9abefa2facd9d5f2989bbc2138e55970e60c4cd
    # bad: [7b4308803bb448efe4d64dcdea03e9d5be6dde9d] 2015-07-29: source-hash-62e2fae93e8894f73560a30ae1e752cbd4c001ad
    git bisect bad 7b4308803bb448efe4d64dcdea03e9d5be6dde9d
    # good: [6e6e48df3b6eb13cf54223cd1ffac16546ec49c2] 2015-07-17: source-hash-14257152b19c08618a107c6eb0f684de11483da8
    git bisect good 6e6e48df3b6eb13cf54223cd1ffac16546ec49c2
    # good: [1cd3607857e7065cfb54d4ea5ca08c78c0ab83d8] 2015-07-23: source-hash-e92a8b92072284fd7c37d7bb3e1e8fe72a185f35
    git bisect good 1cd3607857e7065cfb54d4ea5ca08c78c0ab83d8
    # bad: [5e95a5e0e09583fa603470e648dc904825745efa] 2015-07-26: source-hash-11f24bc2f032b31095663cb09ef948eee2c61f49
    git bisect bad 5e95a5e0e09583fa603470e648dc904825745efa
    # bad: [e229217b7da6f5d9225edffd69287f33299c8684] 2015-07-25: source-hash-fe88fe6f828597fe2645a20c1a07716216a810c3
    git bisect bad e229217b7da6f5d9225edffd69287f33299c8684
    # good: [b28257760a5ff12f099c4c983b6a783cc6de465c] 2015-07-24: source-hash-ba90813d17cf35cfb67585d6f119d3ddb30f5978
    git bisect good b28257760a5ff12f099c4c983b6a783cc6de465c
    # first bad commit: [e229217b7da6f5d9225edffd69287f33299c8684] 2015-07-25: source-hash-fe88fe6f828597fe2645a20c1a07716216a810c3


I am removing keywork bibisecRequest and adding keyword bibisected.

Comment 6 Thomas 2015-12-19 09:24:18 UTC

Where can I find this commit?

http://cgit.freedesktop.org/libreoffice/core/commit/?id=e229217b7da6f5d9225edffd69287f33299c8684 returns nothing.

Comment 7 Terrence Enger 2015-12-19 13:32:06 UTC

Commit e229217 is the id of a binary in the daily debug util bibisect.
For the source code, look at the source hash.  The range
ba90813..fe88fe6 covers 95 commits.  (I have yet to learn how to limit
`git log` to commits to master.  Sigh.)

Comment 8 raal 2016-01-20 21:23:31 UTC

*** Bug 97224 has been marked as a duplicate of this bug. ***

Comment 9 Jean-Baptiste Faure 2016-04-23 23:48:29 UTC

For me it is not a bug because the current About dialog shows more informations than in previous versions. So it has more data to collect as showed by first "bad" commit.

Closing as NotABug and removing regression keyword. Please, feel free to reopen if you disagree.

Best regards. JBF

Comment 10 Thomas Bertels 2016-09-03 01:32:02 UTC

The culprit is this commit: https://cgit.freedesktop.org/libreoffice/core/commit/?id=8cfdd81b70ef37927b40497ffd10034f28335034

These two complex SVG files:
- flat_logo.svg (794 KB vs nothing)
- about.svg (676 KB vs 15 KB)
are the ones that slow down the About dialog. Removing them fixes the problem.

Either we use simpler SVG files or PNG files (like for the splash screen).

Adding bisected, regression and topicUI keywords.

Comment 11 Xisco Faulí 2016-09-26 15:58:40 UTC

Adding Cc: to Christian Lohmaier

Comment 12 Aron Budea 2016-12-07 22:55:55 UTC

Adding Christian, since he wasn't CC-ed before.

Christian, would it be possible to have PNGs shipped instead of those two big SVG files?

Comment 13 Telesto 2017-02-09 17:52:08 UTC

*** Bug 105591 has been marked as a duplicate of this bug. ***

Comment 14 Thomas Bertels 2017-10-04 06:09:09 UTC

Fixed in 6.0 by this commit: https://cgit.freedesktop.org/libreoffice/core/diff/?id=e1c89b12c94c06309032250da0ac7c84d3f96bb6

Comment 15 Thomas Bertels 2017-10-04 06:12:34 UTC

By the way, the previous logos (causing this bug) were PNG files encapsulated in SVG, thus their size.

Comment 16 Thomas Bertels 2018-07-11 09:45:55 UTC

Reopening because newer SVG logos still create a noticeable delay (albeit smaller than before) when opening the about dialog.
Using PNG images instead (like e.g. Firefox) would fix it.

Comment 17 Xisco Faulí 2018-07-12 15:26:12 UTC

Dear [user-name],
This bug has been in RESOLVED FIXED status for more than 1 months.
If the issue is still reproducible with the latest version of LibreOffice from https://www.libreoffice.org/download/libreoffice-fresh/, please report a new issue in https://bugs.documentfoundation.org/enter_bug.cgi providing, if     needed, the steps and documents to reproduce it.
Thanks for your understanding and collaboration.
Closing as RESOLVED FIXED

Comment 18 Thomas Bertels 2019-12-06 08:22:03 UTC

Created attachment 156344 [details]
Optimized about dialog SVG file (fully vectorized)

Here's an optimized version of the SVG file that slows down the about dialog.
Note that the encapsulated PNG file has been replaced by a proper vector version.
Optimized using https://kraken.io/web-interface

Comment 19 Julien Nabet 2019-12-06 08:27:42 UTC

Thomas: as Xisco indicated, please create a new bugtracker.