| Summary: | CRASH when opening specific TXT with Calc under Windows | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Mike Kaganski <mikekaganski> |
| Component: | Calc | Assignee: | Mike Kaganski <mikekaganski> |
| Status: | RESOLVED FIXED | ||
| Severity: | major | CC: | davian818, h3734236, michael.stahl |
| Priority: | high | Keywords: | regression |
| Version: | 5.0.0.0.beta1 | ||
| Hardware: | Other | ||
| OS: | Windows (All) | ||
| See Also: | https://bugs.documentfoundation.org/show_bug.cgi?id=47553 | ||
| Whiteboard: | target:5.1.0 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 112810 | ||
| Attachments: | Bugdoc | ||
Posted a patch to gerrit: https://gerrit.libreoffice.org/19835 Michael, you have fixed the bug 47553 with http://cgit.freedesktop.org/libreoffice/core/commit/?id=cec68bceba9aa1e984d74897fcd7bf4db702d14b, which added the assertion. Could you please take a look at the patch? Thank you. Shouldn't that < be a <= ??? (In reply to MM from comment #2) > Shouldn't that < be a <= ??? No need to set it if it's already equal Mike Kaganski committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=f4a4bbce92fe753678b218c265f7180c306ddf73 tdf#95650: Replace wrong assertion with condition It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |
Created attachment 120356 [details] Bugdoc Opening the TXT in attachment with Calc under Windows, like this: [PathToLO]\soffice.exe --calc [PathTo]\Bug.txt crashes LO. Crash didn't happen with versions prior to 5.0 -> regression. The problem is in UniscribeLayout::LayoutText(ImplLayoutArgs & rArgs), where an assertion is fired on RTL text. Note that the assertion was threr long before 5.0, so it must be change in some other code that revealed this error. Confirming and taking myself.