Bug 95755

Summary: IMPORT: Wrong FORMATTING of a single-cell table in DOCX
Product: LibreOffice Reporter: Mike Kaganski <mikekaganski>
Component: WriterAssignee: Mike Kaganski <mikekaganski>
Status: RESOLVED FIXED    
Severity: normal CC: arrnu0, h3734236, ilmari.lauhakangas, jmadero.dev, lukebenes, timur
Priority: medium    
Version: Inherited From OOo   
Hardware: Other   
OS: All   
See Also: https://bugs.documentfoundation.org/show_bug.cgi?id=56351
https://bugs.documentfoundation.org/show_bug.cgi?id=69647
https://bugs.documentfoundation.org/show_bug.cgi?id=100202
Whiteboard: target:5.2.0
Crash report or crash signature: Regression By:
Attachments: bugdoc and PDFs

Description Mike Kaganski 2015-11-11 21:01:35 UTC
Created attachment 120487 [details]
bugdoc and PDFs

This DOCX file is skewed on import: its picture wrapping is wrong, picture content is displayed wrong because of wrapping (shows OK if wrap is turned off), size of upper frame and table inside of it are too big (should be 10.59 cm instead of 42).

Taken from http://habrahabr.ru/post/269301/
Comment 1 Mike Kaganski 2015-11-11 21:08:41 UTC
Picture display is fixed by turning off Format->Wrap->Enable Contour...
Frame/table display is fixed by setting table alignment to automatic, and frame width to 10.59.
Comment 2 Mike Kaganski 2015-11-11 21:15:59 UTC
Tested with Version: 5.0.3.2 (x64)
Build ID: e5f16313668ac592c1bfb310f4390624e3dbfb75
Locale: ru-RU (ru_RU)

under Win10x64
Comment 3 Joel Madero 2015-11-11 21:31:00 UTC
Hi Mike -

In the future please limit bug reports to one issue per bug report (this is at least two). Makes it a lot easier to triage and a lot easier for a developer to fix. Thanks
Comment 4 Buovjaga 2015-11-12 13:11:22 UTC
Repro.

If Mike will patch then it's fine by me ;)

Win 7 Pro 64-bit Version: 5.1.0.0.alpha1+
Build ID: b216cc1b8096eb60c27f67e8c27b7cd756c75e38
TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2015-11-12_00:06:20
Locale: fi-FI (fi_FI)
Comment 5 Mike Kaganski 2015-11-19 13:10:47 UTC
A patch fixing wrong table size is posted to gerrit:
https://gerrit.libreoffice.org/20052

Picture part is reported as Bug 95930. Thanks Joel and Beluga!
Comment 6 Commit Notification 2015-12-09 13:14:03 UTC
Mike Kaganski committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=769dc61fcaea382518f014c24dffb702b7a50fc6

tdf#95755: Don't discard table properties in endOfRowAction()

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Timur 2015-12-10 08:10:23 UTC
I'll put Inherited as a version, although there's been some changes.
Comment 8 Mike Kaganski 2015-12-10 08:35:18 UTC
*** Bug 56351 has been marked as a duplicate of this bug. ***
Comment 9 Timur 2016-06-03 10:30:08 UTC
Looks backported to 5.1. How can it be confirmed?
Comment 10 Mike Kaganski 2016-06-03 21:42:52 UTC
(In reply to Timur from comment #9)
> Looks backported to 5.1. How can it be confirmed?

No, it isn't. The table width (which is only addressed here) is still wrong in 4.1. Only image wrap issue is, but it was handled in bug 60351 (bug 95930 filed from here was duplicate of it).