| Summary: | UI: Ruler tabstops don't account for spacing to contents in table/frame | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | tmacalp <tmacalp> |
| Component: | Writer | Assignee: | Justin L <jluth> |
| Status: | VERIFIED FIXED | ||
| Severity: | minor | CC: | ilmari.lauhakangas, jluth, kaplanlior, mikekaganski, preechaw, quikee, xiscofauli |
| Priority: | medium | Keywords: | bibisected, bisected, regression |
| Version: | 4.2.0.4 release | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.documentfoundation.org/show_bug.cgi?id=85028 | ||
| Whiteboard: | target:7.4.0 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 107834, 108629 | ||
| Attachments: |
Example document demonstrating ruler with wrong tabstops
spacing_tabstopB.odt: add a few more scenarios to take into account. |
||
|
Description
tmacalp
2015-11-17 19:52:47 UTC
Repro. Win 7 Pro 64-bit Version: 5.1.0.0.alpha1+ Build ID: b216cc1b8096eb60c27f67e8c27b7cd756c75e38 TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2015-11-12_00:06:20 Locale: fi-FI (fi_FI) Migrating Whiteboard tags to Keywords: (bibisected) [NinjaEdit] Seems to be the same as bug 96558 Trent: you can decide how to dupe. *** Bug 96558 has been marked as a duplicate of this bug. *** It looks like this regression was introduced by commit 681f43274541fc4ab5e8c05739b0d74aa5f17be8 Author: Tomaž Vajngerl <quikee@gmail.com> Date: Thu Sep 12 21:05:14 2013 +0200 ruler: RTL fixes for indents in tables and columns Change-Id: I6c0a819e4a294fcf50c96a51bb9eea3ddef84c57 Adding Cc: to Tomaž Vajngerl Still reproducible in: Version: 6.1.0.3 Build ID: efb621ed25068d70781dc026f7e9c5187a4decd1 CPU threads: 4; OS: Mac OS X 10.9.5; UI render: GL; Locale: en-US (en.UTF-8); Calc: group threaded Dear tmacalp, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug Dear tmacalp, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug Used bibisect-42max to confirm this (although it seemed true only for table. Frame was already broken). Unfortunately, a broken build means a range of five days of commits to review. That's really a shame because I'm not certain comment 5's conclusion is correct. Half of that commit includes just name changes. The bulk of the change is in ApplyIndents(), and that function is not even called at all when I open the test document. https://cgit.freedesktop.org/libreoffice/core/log/?id=681f43274541fc4ab5e8c05739b0d74aa5f17be8&qt=range&q=5c2ba4aad61ce2c7c661202ae7ed26e1859c5216..6fbf0762abf2947d2774d685414bd409361bc1fa The frame part of the bug document already is at 2in instead of 3in in LO 3.5. *** Bug 85028 has been marked as a duplicate of this bug. *** Created attachment 178367 [details] spacing_tabstopB.odt: add a few more scenarios to take into account. proposed fix at http://gerrit.libreoffice.org/c/core/+/130125 For the record, the regressive commit was actually by author Tomaž Vajngerl on 2013-09-15 15:34:15 +0200 commit 47a77d7dbc427e51421e2df8d59695834cb74980 Ruler: disable snapping, tooltips https://cgit.freedesktop.org/libreoffice/core/commit/?id=47a77d7dbc427e51421e2df8d59695834cb74980 Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/e87f9b4fa158b917bb38fc00513bae7f94024e58 tdf#95882 svxruler: restore adjustment for borders It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Compared with older version and now it seems to be working as expected Arch Linux 64-bit Version: 7.4.0.0.alpha0+ / LibreOffice Community Build ID: 8f2b1b1cb84e1ae3139eb90b8efdf61e608adbad CPU threads: 8; OS: Linux 5.16; UI render: default; VCL: kf5 (cairo+xcb) Locale: fi-FI (fi_FI.UTF-8); UI: en-US Calc: threaded Jumbo Built on 24 February 2022 |