| Summary: | FILESAVE: Paragraph White Fill added to some tables in DOCX export | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Luke <lukebenes> |
| Component: | Writer | Assignee: | Justin L <jluth> |
| Status: | VERIFIED FIXED | ||
| Severity: | normal | CC: | franklin, ilmari.lauhakangas, jluth, mikekaganski, vmiklos |
| Priority: | medium | Keywords: | bisected, preBibisect |
| Version: | 5.0.4.2 release | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
https://bugs.documentfoundation.org/show_bug.cgi?id=100202 https://bugs.documentfoundation.org/show_bug.cgi?id=98882 https://bugs.documentfoundation.org/show_bug.cgi?id=88583 |
||
| Whiteboard: | target:5.3.0 target:5.2.2 | ||
| Crash report or crash signature: | Regression By: | ||
| Attachments: | Test document | ||
|
Description
Luke
2016-01-13 05:06:10 UTC
Repro. In 4.3 the backgrounds of the affected cells are white already on opening, so this is actually progress :) Win 7 Pro 64-bit, Version: 5.0.4.2 (x64) Build ID: 2b9802c1994aa0b7dc6079e128979269cf95bc78 Locale: fi-FI (fi_FI) Version: 5.2.0.0.alpha0+ Build ID: 6b65a0e83c4798f117be61af91dbaebdc85e94b7 CPU Threads: 4; OS Version: Windows 6.1; UI Render: default; TinderBox: Win-x86@39, Branch:master, Time: 2016-01-21_03:41:08 Locale: fi-FI (fi_FI) Later in 5.2, it has reverted back to importing/opening with a white paragraph fill again due to commit https://cgit.freedesktop.org/libreoffice/core/commit/?id=eae2331f83bd58bacccd898d60f6c5f54856c036. Specifically from: +if (sConvertedStyleName != "Standard") StyleSheetTable_Impl::SetPropertiesToDefault(xStyle); Miklos and Justin, We have 2 separate issues now. 1) original FILESAVE: round-trip bug 2) New FILEOPEN: Regression from https://cgit.freedesktop.org/libreoffice/core/commit/?id=eae2331f83bd58bacccd898d60f6c5f54856c036. Do you want to track them both here, reopen Bug 95755 for 2), or file a new bug report for 2)? (In reply to Luke from comment #3) > Do you want to track them both here, reopen Bug 95755 for 2), or file a new > bug report for 2)? Bug 95755 shouldn't be reopened for this, because this issue had never been its subject. (In reply to Luke from comment #3) Just track everything in one bug for now. Comment #2 was just to help the developers land in the right place. The "white paragraph fill on import" was probably inherited from OOo - it goes back to last36onmaster at least - which was the earliest I could test on 16.04. The spot where the import kept the paragraph as no-fill came from commit 24077b2d52ab3d0fd0db5afb25d8b94b62386e3e https://cgit.freedesktop.org/libreoffice/core/commit/?id=24077b2d52ab3d0fd0db5afb25d8b94b62386e3e Author: Miklos Vajna <vmiklos@collabora.co.uk> CommitDate: Sun Feb 1 01:48:38 2015 +0100 writerfilter: import paragraph color as fill attributes proposed fix https://gerrit.libreoffice.org/#/c/27915 Justin Luth committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=2a174c2f6fd58a31eb150b84de83e5ba1c4d3fed tdf#97090 writerfilter - don't fill_SOLID with auto color It will be available in 5.3.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Both issues have been fixed. Verified with Version: 5.3.0.0.alpha0+ (x64). Thank you Justin! Justin Luth committed a patch related to this issue. It has been pushed to "libreoffice-5-2": http://cgit.freedesktop.org/libreoffice/core/commit/?id=834ae34d7f16f37078bf0065af8bff29f9d5c422&h=libreoffice-5-2 tdf#97090 writerfilter - don't fill_SOLID with auto color It will be available in 5.2.2. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. *** Bug 102905 has been marked as a duplicate of this bug. *** |