| Summary: | Beanshell Editor: Shift-Tab doesn't work | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Samuel Mehrbrodt (allotropia) <samuel.mehrbrodt> |
| Component: | LibreOffice | Assignee: | Andreas Heinisch <andreas.heinisch> |
| Status: | RESOLVED FIXED | ||
| Severity: | enhancement | CC: | cno, ilmari.lauhakangas, samuel.mehrbrodt |
| Priority: | medium | ||
| Version: | Inherited From OOo | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | target:6.3.0 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 97639 | ||
|
Description
Samuel Mehrbrodt (allotropia)
2016-02-08 11:42:52 UTC
Oops .. Tab does work, but Shift-Tab doesn't. Confirmed. Win 7 Pro 64-bit Version: 5.2.0.0.alpha0+ Build ID: a6f876d45bd4e41a7143594a6cb11b6893a0f620 CPU Threads: 4; OS Version: Windows 6.1; UI Render: default; TinderBox: Win-x86@39, Branch:master, Time: 2016-02-11_00:07:38 Locale: fi-FI (fi_FI) A short question: if I Shift-Tab in a line without any tab, what should be the intended behaviour? For instance, in Eclipse, Shift-Tab removes only tabs at the beginning of a line until no more tabs are present. (In reply to Andreas Heinisch from comment #3) > A short question: if I Shift-Tab in a line without any tab, what should be > the intended behaviour? > > For instance, in Eclipse, Shift-Tab removes only tabs at the beginning of a > line until no more tabs are present. Yeah just do something sensible then, maybe just copy Eclipse's behavior. Andreas Heinisch committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/e875a317c4adf00bbad00fb8176c26cd1a66973e%5E%21 tdf#97635 Added unindentation using shift-tab (mimicked eclipse behavior) It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. I did some tests with the shift+tab patch and I don't know if we should move the functionality to the keyPressed function? This would allow the user to press the shift+tab continuously and not only once per input. (In reply to Andreas Heinisch from comment #6) > I did some tests with the shift+tab patch and I don't know if we should move > the functionality to the keyPressed function? This would allow the user to > press the shift+tab continuously and not only once per input. Ah good point, feel free to create a follow-up patch for that. Andreas Heinisch committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/9ee0a1f16682139c5be28a05d33e980123da4c6f%5E%21 tdf#97635 Added unindentation using shift-tab (mimicked eclipse's behavior) It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |