| Summary: | Drop 'static' for functions inside unnamed namespaces | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | How can I remove my account? <tml> |
| Component: | LibreOffice | Assignee: | Not Assigned <libreoffice-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | dtardon, h3734236, mentoring, sberg.fun |
| Priority: | medium | Keywords: | difficultyBeginner, easyHack, skillCpp |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | target:5.2.0 | ||
| Crash report or crash signature: | Regression By: | ||
|
Description
How can I remove my account?
2016-02-18 09:08:32 UTC
(In reply to Tor Lillqvist from comment #0) > As such, this task is probably too easy to qualify somebody as a potential > GSoC participant for us. But if you write a Clang plug-in to do it instead > of doing it manually, we will be more impressed. For how to write a Clang plugin for LO, see compilerplugins/README in the LO source tree, and the links from there. Change default CC for Easy Hacks (LibreOffice Dev List -> JanI) [NinjaEdit] Please don't assign to yourself--this is a task multiple people can work on in parallel. Hi, Sorry for the assignment. I would like to work on it. I'd like to write a Clang plugin. However, I have a question. Should this issue be checked in the entire project, in every c++ code? Another question is that is this comment field the right place to ask questions about the bug? (In reply to Tamas Bunth from comment #4) > Hi, > Sorry for the assignment. I would like to work on it. I'd like to write a > Clang plugin. However, I have a question. Should this issue be checked in > the entire project, in every c++ code? Another question is that is this > comment field the right place to ask questions about the bug? Welcome, we have made a step by step guide to help new people: https://wiki.documentfoundation.org/Development/GetInvolved Of course it should be checked over the entire project, writing a Clang plugin takes care of that. The comment field is in general the right place and the code pointer you need is in comment #1. You can also use mail and IRC (see wiki) for questions. Should the clang plugin rewrite these functions or just warn about them? Regards Jakub: The more the better, of course;) But note that Tamas already is (claims to be) working on this. Wastack committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=7218090791da47aa37292f16bc1fa6f30607a58a tdf#97966 Drop static keywords from two functions inside an unnamed namespace It will be available in 5.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Wastack committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=83452dd0836fe0da96095a322231d837fc31934b tdf#97966 redundant static keywords removed 6 It will be available in 5.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Wastack committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=951917e73cc5d52453830daa47fd30b5fd834bc0 tdf#97966: Remove 'static' keywords It will be available in 5.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Wastack committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=b91fb8465cdaaff077b9f5c2a73cfc873350126f tdf#97966: Remove 'static' keywords It will be available in 5.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Wastack committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=7a0b8decb7d81fefced39ee04368dd0112e8ac28 tdf#97966: Remove 'static' keywords It will be available in 5.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Wastack committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=018c6adf85097d07a0b0fbce3d7155ca5a369ae1 tdf#97966: Remove 'static' keywords It will be available in 5.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Wastack committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=9a13cff64783a7de3dce7d484c150605bd42a4d6 tdf#97966: Remove 'static' keywords It will be available in 5.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Wastack committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=ce549d2a09ad9884a7e598162cf0ca6b6bc3150c tdf#97966: Remove 'static' keywords It will be available in 5.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. I made a plugin but I couldn't bulid it, not even the tutorial1. I made a copy to the clang folder. For the command "make compilerplugins" I got "Nothing to be done for 'compilerplugins'". I tried "make compilerplugins.clear" but it doesn't help: "No rule to make target `compilerplugins.clear'" I followed this doc: https://wiki.documentfoundation.org/Development/Clang_plugins (In reply to Tamas Bunth from comment #16) > For the command "make compilerplugins" I got "Nothing to be done for > 'compilerplugins'". > > I tried "make compilerplugins.clear" but it doesn't help: "No rule to make > target `compilerplugins.clear'" > > I followed this doc: > https://wiki.documentfoundation.org/Development/Clang_plugins Did you configure the LO build with --enable-compiler-plugins (it is disabled by default unless you also configured --enable-dbgutil)? Do you have the LLVM/Clang development headers installed (if you use a distro's clang package, they often come in an additional package that needs to be installed explicitly, e.g. see the "Clang Setup" slide of <http://conference.libreoffice.org/assets/Conference/Aarhus/Slides/SBergmanLOCON2015-plugin.pdf>)? (In reply to Stephan Bergmann from comment #17) > Did you configure the LO build with --enable-compiler-plugins (it is > disabled by default unless you also configured --enable-dbgutil)? Do you > have the LLVM/Clang development headers installed (if you use a distro's > clang package, they often come in an additional package that needs to be > installed explicitly, e.g. see the "Clang Setup" slide of > <http://conference.libreoffice.org/assets/Conference/Aarhus/Slides/ > SBergmanLOCON2015-plugin.pdf>)? Solved, thank you. Wastack committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=14060e76e33cfb305c1469fecf7db688bf8a8858 tdf#97966 Drop 'static' keywords It will be available in 5.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Wastack committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=0b8e5ca5a25dfe9f20b098fdbd94f7e9f223f5c7 tdf#97966 Drop 'static' keywords It will be available in 5.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Wastack committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=62d1632498d92b6e73b952c9d379edebe3052341 tdf#97966 Drop 'static' keywords It will be available in 5.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Wastack committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=9e596250a6e968c5d1e2fb0de582ae242e02acf9 tdf#97966 Drop 'static' keywords It will be available in 5.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Wastack committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=20ba5d464a9fba3090af6a644a331ee237356fea tdf#97966 Drop 'static' keywords It will be available in 5.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Wastack committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=1271eadfac7e77ff7b249e64be3857ffdc0a261c tdf#97966 Drop 'static' keywords It will be available in 5.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Wastack committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=eea3f508c35f8f391825761ab6e1f3fbfb2fd0c1 tdf#97966 Drop 'static' keywords It will be available in 5.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Wastack committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=cb495d71063d60da46215a2510736eccd910fa7a tdf#97966 Drop 'static' keywords It will be available in 5.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Wastack committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=9af411abce1e22d55b73d5bbac3b7a6a8535eb3b tdf#97966 Drop 'static' keywords It will be available in 5.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Wastack committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=84fd42c1f58627f3e03ee6062fa2812a4890d941 tdf#97966 Drop 'static' keywords It will be available in 5.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Wastack committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=e097e419ee5c47239262a16526f4e37775fb2004 tdf#97966 Compiler plugin It will be available in 5.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. We probably can resolve this bug now that there is a plug-in that will mark all occurences? |