| Summary: | Calc format shows incorrect translations for dates written in words in Ukrainian language | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | sunweb |
| Component: | Localization | Assignee: | David Tardon <dtardon> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | dtardon, h3734236 |
| Priority: | medium | ||
| Version: | 5.0.5.2 release | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | target:5.2.0 | ||
| Crash report or crash signature: | Regression By: | ||
| Attachments: |
locale_improvements
locale_improvements |
||
|
Description
sunweb
2016-04-06 06:23:10 UTC
The locale data description for Ukrainian is incomplete. If there is no coding involved i might help. David Tardon committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=f8b6a503af8a203ed85f2c502a57c802806e5c75 tdf#99110 add genitive cases for months for uk It will be available in 5.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. David Tardon committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=811219418cc2ca17f7ab31d13835a664a45d4acf tdf#99110 translate reserved words for uk It will be available in 5.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. David Tardon committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=97a0893f1db495830e81a9ff4d073adaa8078d74 tdf#99110 translate currency for uk It will be available in 5.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. (In reply to sunweb from comment #2) > If there is no coding involved i might help. You can check the Ukrainian words/expressions in https://cgit.freedesktop.org/libreoffice/core/diff/i18npool/source/localedata/data/uk_UA.xml?id=f8b6a503af8a203ed85f2c502a57c802806e5c75 for mistakes. Looks good, thank you! Oops, I meant https://cgit.freedesktop.org/libreoffice/core/tree/i18npool/source/localedata/data/uk_UA.xml . The commit I linked earlier is obviously correct, because I used your list... (In reply to David Tardon from comment #8) > Oops, I meant > https://cgit.freedesktop.org/libreoffice/core/tree/i18npool/source/ > localedata/data/uk_UA.xml . The commit I linked earlier is obviously > correct, because I used your list... Overall everything is good. Though we use dot rather than slash as date separator And "NNNNMMMM D, YYYY" produces different result rather than in English(USA) to fix it space is needed and coma separator because of writing rules "NNNN, MMMM D, YYYY". I've made some fixes and uploaded a txt file and added it as an attachment. Created attachment 124146 [details]
locale_improvements
Created attachment 124149 [details]
locale_improvements
Found a few more inconsistencies. Ignore previous locale_improvements attachment.
After downloading a test build i've found out one more little problem. I am not sure if its possible to fix soon but just to let you know. If month is located after day then it supposed to be "квітня" and if it is before the day then "Квітень". Also it appears that dot or comma after month also result in "Квітень" instead of "квітня". now: D MMMM, - 7 Квітень, MMMM D - квітня 7 expected: D MMMM, - 7 квітня, MMMM D - Квітень 7 (In reply to sunweb from comment #12) > After downloading a test build i've found out one more little problem. I am > not sure if its possible to fix soon but just to let you know. > > If month is located after day then it supposed to be "квітня" and if it is > before the day then "Квітень". Hm, that should be so already. I'll check. > Also it appears that dot or comma after month also result in "Квітень" > instead of "квітня". Unfortunately, in this case the code assumes that the word is in nominative case. And I do not think it would be easy to change that. David Tardon committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=f025b7ea8d2af57fcbc8aa69a8dae636d9219ad3 tdf#99110 use the right case It will be available in 5.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. sunweb committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=2c9f86854d58bf544b9c596f23844a0d857078ee tdf#99110 more improvements for formatting dates for uk It will be available in 5.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. (In reply to David Tardon from comment #13) > (In reply to sunweb from comment #12) > > Also it appears that dot or comma after month also result in "Квітень" > > instead of "квітня". > > Unfortunately, in this case the code assumes that the word is in nominative > case. And I do not think it would be easy to change that. Maybe it would simple to add a special character(or better yet a combination of those that aren't useful for dates) for that before or after month? At this point you can't add double and single quotes, comma and dot because it will change case to nominative. It will simplify and fix things right away and won't restrict dots, comma, etc usage. MMMM^^ - квітня MMMM - Квітень Or the other way around Or even better. Bring in case sensitivity for months(and days of week for more consistency): - first small "m" tells that the whole month will be written in lower case, and it doesn't matter if there're some upper case letters afterwards: mmmm - december mMmm - december mmMm - december mmmM - december ... mmmm^^ - квітня mmmm - квітень ... mmm - dec mMM - dec mmM - dec - if all "M" are upper case then all letters are upper cased as well: MMMM - DECEMBER MMM - DEC MMMM^^ - КВІТНЯ MMMM - КВІТЕНЬ - if first "M" is upper cased but atleast one letter afterwards is lower cased then only first letter is capitalized: Mmmm - December MmmM - December MmMM - December MMmM - December ... Mmmm^^ - Квітня Mmmm - Квітень Mmm - Dec MmM - Dec MMm - Dec |