Created attachment 125557 [details] No shortcuts are visible for the buttons 1. Edit a document and make a change 2. Close the document (Ctrl+F4) Calc/Writer et al. will open a dialog titled "Save Document", with three buttons: "Don't save", "Cancel" and "Save". For consistency with other applications, 'N' should be the accelerator for "Don't save". Right now the shortcut for that is an awkward Alt+D, which isn't discoverable until the user presses Alt.
UX needs to decide this.
Sorry, that is by design and implemented for bug 92630 Those are not "shortcuts" those are "accelerators", refactoring was done to make their behavior compliant with GTK3 and only show the "localized" nemonic for the "accelerators" when the <Alt> key is pressed. Assigning an actual shortcut is not appropriate. Resolving duplicate of bug 99326, the final form there is still evolving as some prefer LibreOffice provide ability to optionally override the use of <alt> key and accelerator behavior. *** This bug has been marked as a duplicate of bug 99326 ***
@V Stuart: do you think users care more about the difference between "shortcut" and "accelerator" (I mentioned both terms in my report BTW), or about their muscle memory of pressing "N"?
I agree with Stuart that we should keep the first letter as accelerator. Would be interesting, by the way, where you see a missing consistency. Anyway, to improve the situation the text should be renamed to something like "Exit anyway" since "Don't save" doesn't tell the user how the operation is going on. Quite often this button is labeled "Discard changes". Good solution too.
(In reply to Dan Dascalescu from comment #3) > @V Stuart: do you think users care more about the difference between > "shortcut" and "accelerator" (I mentioned both terms in my report BTW), or > about their muscle memory of pressing "N"? What localization, what OS/DE? Why we in this BZ context care... Accelerators normally are translated and receive appropriate mnemonic. Short-cuts are normally set elsewhere and are retained across localizations. The "Discard/Close Without Saving/Don't Save" takes an accelerator. And actually the dialog discard any changes, and its mnemonic has been changed several times. Most recently for bug 82017 -- "Close/Save confirmation dialog doesn't use CMD-D for don't save" for reasonable accommodation of the OS X side. The .ui Glade GTK button object remains labeled "discard". 3.3 -> 3.6 label and accelerator was "~Discard" 4.0 -> 4.3 label and accelerator was "Close _Without Saving" (note move to .ui) 4.4 -> 5.2 label and accelerator is "_Don`t Save" I would argue that the original "Discard" is the better *localizable* label but there is no real reason to revert or change from commint https://cgit.freedesktop.org/libreoffice/core/commit/?id=10abd657aacea884f520c97054625a94184c4aca and certainly no reason to adopt an "N" entry. Otherwise the only issue here is that the accelerator is not revealed--hence the dupe to bug 99326.
FWIW, I’ve already changed the mnemonic of this button once, because someone found it non-intuitive: https://cgit.freedesktop.org/libreoffice/core/commit/?id=10abd657aacea884f520c97054625a94184c4aca I’m reluctant to change it again to something else.