Steps: 1) Open writer 2) Insert an image 3) Right click > Compress Image The dialog was modified in 5.1 and 5.2 to include percentage sliders and it isnt possible to shrink it down. Version: 5.2.0.0.beta1+ Build ID: 90e3e04841081b9c03ea54f1d5ca439a7a9ce1dd CPU Threads: 2; OS Version: Linux 3.19; UI Render: default; TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:libreoffice-5-2, Time: 2016-06-04_01:52:51 Locale: en-US (en_US.UTF-8)
Created attachment 125611 [details] 5.0 v 5.2
Are useful those sliders? Not easy to fix an exact value. I think they are only fine with live preview. Could be better instead one up-down control. two for every field, one with +-1 and another one with a value proportional to the range of values +-5|+-|10+-50|+-100. It would be nice for all controls with values on all LibreOffice's dialog.
The dialog grew larger because it now has redundant sets of controls: you can tweak a value by controlling both the spin buttons and the sliders. There are several ways to fix this large dialog: - Have just spin buttons and remove the sliders - Have just the sliders (we’ll need to add ticks to them), and remove the spin buttons - Make the “Image Information” section collapsible (it was in the first version of this dialog, but I removed that… I can change it back if you guys wish). @Tomaž, would you like to chime in? :-)
@Adolfo: It would be great to have the slider plus spinbox like we have for transparency in the area content panel of the sidebar, but in this case, i'd say we should go for a combobox with presets like we have in the dialog for resolution.
Yeah.. maybe a combo box would be best here. Also it would probably be good to have PNG and JPG as a combo box and change Compression / Quality slider depending on what is selected (hiding instead of disabling).
Yes combining JPG and PNG into a single toggle would be good to reduce the height of the dialog, though i think retaining them as radio buttons is better than a combo box as it gives 1 click switching. As we are labeling it 'JPG compression', we should likely label it 'PNG compression' rather 'lossless compression' to be consistent.
(In reply to m.a.riosv from comment #2) > Are useful those sliders? Sliders are good to quickly set a value on a percentual basis, meaning the exact number is not important. The slider/spinner combination as implemented provides the best of both world. About consistency: bug 59570 points to a wrong implementation of this concept. (In reply to Yousuf (Jay) Philips from comment #0) > The dialog was modified in 5.1 and 5.2 to include percentage sliders and it > isnt possible to shrink it down. Dialogs have a fix size. The discussion was on the mailing list (http://listarchives.libreoffice.org/global/design/msg07373.html), see also bug 96999 or bug 87495. (In reply to Tomaz Vajngerl from comment #5) > Yeah.. maybe a combo box would be best here. The combo box is good for a selection of one out of many items. The radio button is the preferred control for a single selection with only a few items and when the options are not clear. I would keep it as it is. Two points: The slider no not respect the theme or are not implemented as standard controls. And the numeric input is overlong, better place it right of the slider with a smaller width.
(In reply to Heiko Tietze from comment #7) > Dialogs have a fix size. The discussion was on the mailing list > (http://listarchives.libreoffice.org/global/design/msg07373.html), see also > bug 96999 or bug 87495. Dialogs have fixed sizes when the resizing of the dialog wouldnt expose any more useful information, which is the same idea behind not having the sidebar resizable. We have resizable dialogs like for hyperlink (url can be very long) and open remote file (file names can be very long). This dialog doesnt need to be resizable, but as it was so wide, a user would assume it could be shrunk down, which was what i getting at. :D
Caolán McNamara committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=380b2d2e449eee1e794efa1b16b69289419a9a66 Resolves: tdf#100340 make compress graphic dialog less wide It will be available in 5.3.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
In the export graphic dialog we use the terms "JPEG Compression" and "PNG Quality" and in that dialog we have the slider to the left of the spin widget so I follow that pattern here. Then moved the blocks around to put the resolution widgets on the right pane and the text info at the bottom and rejigged the "calculate" button. So new dialog is less wide than the original dialog.
Thanks for the work Caolan as it looks alot better. (In reply to Caolán McNamara from comment #10) > In the export graphic dialog we use the terms "JPEG Compression" and "PNG > Quality" and in that dialog we have the slider to the left of the spin > widget so I follow that pattern here. Can you let me know where this dialog is, as i wasnt able to find it. Using "PNG Quality" doesnt make sense as it uses lossless compression so the quality doesnt change. > Then moved the blocks around to put > the resolution widgets on the right pane and the text info at the bottom and > rejigged the "calculate" button. So new dialog is less wide than the > original dialog. Looks fine, but now there is a large space above 'Image Information' because of the Interpolation label and field. So i've sent in a patch for alternative compression labels, smaller sliders (this shrinks down the dialog a little more), and adjusting the indent of the image information labels with the radio buttons in the compression options. https://gerrit.libreoffice.org/27205 Wasnt able to deal with the spacing above 'Image Information', so i'll leave that to whomever can do it.
(In reply to Commit Notification from comment #9) > Caolán McNamara committed a patch related to this issue. > Affected users are encouraged to test the fix and report feedback. Looks nice, and I don't have a problem with whitespace. However, resizing is still possible (please disable). -> Reopening because of this HIG violation. (In reply to Yousuf (Jay) Philips from comment #11) > So i've sent in a patch for alternative compression labels, smaller sliders > (this shrinks down the dialog a little more), and adjusting the indent of > the image information labels with the radio buttons in the compression > options. Caolán's version is a better sized, as yours has almost square dimensions. About the text: it always looks awkward when a caption contains explanation (whether or not a compression is lossless should the user learn somewhere else).
(In reply to Heiko Tietze from comment #12) > Looks nice, and I don't have a problem with whitespace. However, resizing is > still possible (please disable). -> Reopening because of this HIG violation. Added disabling of resize to my patch. > Caolán's version is a better sized, as yours has almost square dimensions. Dont think the dimension is important, it is more important that the dialog doesnt have oversized controls when it doesnt need to, which is an advantage for smaller screens. > About the text: it always looks awkward when a caption contains explanation > (whether or not a compression is lossless should the user learn somewhere > else). It is useful to explain to users the difference between JPG and PNG compression, especially if they didnt already know, and we have sufficient space to do so and not only rely on tooltips to explain labels, though we dont have any tooltips for these labels.
"Can you let me know where this dialog is, as i wasnt able to find it. Using "PNG Quality" doesnt make sense as it uses lossless compression so the quality doesnt change." insert an image into draw/impress, select it and use file->export, select png/jpg format and save, there will be a PNG/JPEG Options dialog. I had it wrong of course, the PNG one says "Compression" the JPG one is "Quality".
Yousuf Philips committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=0bd3daf959a6ac94e2538f6b9b7f7c6892596210 tdf#100340 reduce the compress graphic dialog a little more It will be available in 5.3.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Caolán McNamara committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=c4feea24c28b38c81205accbb7ae24a61f0b94e0 Related: tdf#100340 use same terms as export graphic dialog It will be available in 5.3.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Lets leave this as fixed if there turns out to be other minor issus, this was marked as "regression", suggesting a rather serious problem. Any more polishing can have a new bug for it, so keeping it off the "disaster" list
(In reply to Caolán McNamara from comment #14) > I had it > wrong of course, the PNG one says "Compression" the JPG one is "Quality". You've repeated the same mistake as last time in your latest patch and used 'JPEG Compression' and 'PNG Quality', when it should be 'JPEG Quality' and 'PNG Compression'. :D