Bug 101291 - Crop handles are ugly in Galaxy and HighContrast
Summary: Crop handles are ugly in Galaxy and HighContrast
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
5.3.0.0.alpha0+
Hardware: x86 (IA32) All
: low minor
Assignee: Regina Henschel
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-04 13:00 UTC by Regina Henschel
Modified: 2016-08-17 07:34 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:

Attachments
ugly handles in new version (18.96 KB, image/png)
2016-08-04 13:00 UTC, Regina Henschel 		Details
correct handles in AOO (18.73 KB, image/png)
2016-08-04 13:01 UTC, Regina Henschel 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Regina Henschel 2016-08-04 13:00:40 UTC 
Created attachment 126573 [details]
ugly handles in new version

Core has been changed some time ago and got new pixel counting for to fetch the parts of the file cropmarkers.png to render the crop markers. The new values fit fine for Tango and Breeze but not for Galaxy and Highcontrast. If you open the file /core/icon-themes/tango/svx/res/cropmarkers.png and compare it to /core/icon-themes/galaxy/svx/res/cropmarkers.png and /core/icon-themes/hicontrast/svx/res/cropmarkers.png, you notice, that the Galaxy and Highcontrast files have different dimensions.

The Galaxy and Highcontrast versions of the file cropmarkers.png should be adapted to the dimension of the Tango version.
Comment 1 Regina Henschel 2016-08-04 13:01:21 UTC 
Created attachment 126574 [details]
correct handles in AOO
Comment 2 Buovjaga 2016-08-07 15:40:34 UTC 
Confirmed.

Arch Linux 64-bit, KDE Plasma 5
Version: 5.3.0.0.alpha0+
Build ID: f3d26af51588af441f62fb69bb7a5432845226ac
CPU Threads: 8; OS Version: Linux 4.6; UI Render: default; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group
Built on August 5th 2016
Comment 3 Regina Henschel 2016-08-17 00:06:44 UTC 
Fixed with commit 7ffe3d742ee992cd704a52d9aeb9b131dded7d14. (I had a typo in the commit message and therefore the automatic notification didn't work.)
Comment 4 steve 2016-08-17 07:34:26 UTC 
removing keyword needsDevEval since this is fixed.