Bug 102917 - After insert of cell comment escape key causes Text Formatting toolbar to open/close
Summary: After insert of cell comment escape key causes Text Formatting toolbar to ope...
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
5.2.0.4 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Calc-Comments
  Show dependency treegraph
 
Reported: 2016-10-01 23:10 UTC by Robert Gonzalez MX
Modified: 2018-10-07 22:05 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Calc test file (9.33 KB, application/vnd.oasis.opendocument.spreadsheet)
2016-10-01 23:12 UTC, Robert Gonzalez MX
Details
Screenshots and descriptions (57.33 KB, application/vnd.oasis.opendocument.text)
2016-10-01 23:12 UTC, Robert Gonzalez MX
Details
Screenshot in OpenSuse Leap (41.48 KB, image/png)
2016-10-02 17:12 UTC, Robert Gonzalez MX
Details
Cursor screenshot in OpenSuse Leap (302 bytes, image/png)
2016-10-02 17:13 UTC, Robert Gonzalez MX
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Gonzalez MX 2016-10-01 23:10:23 UTC
User-Agent:       Mozilla/5.0 (Windows NT 10.0; WOW64; rv:49.0) Gecko/20100101 Firefox/49.0
Build Identifier: Version: 5.2.2.2 Build ID: 8f96e87c890bf8fa77463cd4b640a2312823f3ad

I have noticed this behavior earlier in December and January, just before the release of the 5.2 version in February, but I was not sure if was a bug.

Problem description:
Canceling the insertion of a comment causes that when the ESC key is used, the comment format toolbar to display, replacing the cell format toolbar, even with no comment active.


Reproducible: Always

Steps to Reproduce:
1. Open a new Calc spreadsheet.
2. Select any cell.
3. Right click and select the option to insert comment or with the toolbar.
Notice and observe that the comment format toolbar displays and replaces the cell format toolbar.

4. Cancel the insertion with the ESC key or clicking in the same or other cell.

Notice and observe that the comment format toolbar closes and the cell format toolbar displays.

5. Now use the ESC key once.

Notice and observe that even without the comment, in that cell or another, the comment format toolbar displays replacing the cell format toolbar.

6. Use the ESC key again and the comment toolbar closes and restores the cell format toolbar.


With each use of the ESC key the toolbars change.

Even if a new comment is inserted in a cell. After that, testing the ESC key shows the problem.

This causes trouble with the data insertion and edition, and it was not present in Calc 5.1.5

Also in an existing comment the option to “edit comment” has the same behavior.

Steps to reproduce with the “Edit comment” option.
1. Select commented cell
2. Right click and select “Edit Comment” option
3. Click on the same commented cell or any other cell with out any changes
4. Test with the ESC key and see the format toolbars change


Steps that behave correctly
Close Calc and star again
1. In an existing comment.
2. Right click and select Show Comment.
3. Click to edit the frame.
3a. Second click edit the text of the comment.
3b. or double click to edit the text of the comment immediately.
4. ESC to cancel the edition

Testing the ESC key some times shows that here there is no problem and works as expected.




Expected Results:  
The comment format toolbar should only be present when a comment is activly edited

Tested with Version: 5.2.2.2
Build ID: 8f96e87c890bf8fa77463cd4b640a2312823f3ad
CPU Threads: 8; OS Version: Windows 6.2; UI Render: default; 
Locale: es-MX (es_MX); Calc: group
and

Version: 5.3.0.0.alpha0+
Build ID: a87a31602165cb2a37c32f5928e4f9daade7271d
CPU Threads: 8; OS Version: Windows 6.19; UI Render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2016-09-29_04:18:44
Locale: es-MX (es_MX); Calc: group



Reset User Profile?No
Comment 1 Robert Gonzalez MX 2016-10-01 23:12:24 UTC
Created attachment 127771 [details]
Calc test file
Comment 2 Robert Gonzalez MX 2016-10-01 23:12:59 UTC
Created attachment 127772 [details]
Screenshots and descriptions
Comment 3 Robert Gonzalez MX 2016-10-01 23:14:54 UTC
I don't remember in which version first started, but remember i see it in december 2015, juanuary 2016.
Comment 4 m_a_riosv 2016-10-02 11:02:10 UTC
I can't reproduce
Win10x64
Version: 5.2.2.2 (x64)
 Build ID: 8f96e87c890bf8fa77463cd4b640a2312823f3ad
 CPU Threads: 4; OS Version: Windows 6.19; UI Render: GL; 
 Locale: es-ES (es_ES); Calc: CL
Version: 5.3.0.0.alpha0+
 Build ID: cf4ff92144726a91508fcaf4be21170eac5cb99a
 CPU Threads: 4; OS Version: Windows 6.19; UI Render: default; 
 TinderBox: Win-x86@42, Branch:master, Time: 2016-10-01_00:13:03
 Locale: es-ES (es_ES); Calc: CL

Please try resetting the user profile, sometimes solves strange issues.
https://wiki.documentfoundation.org/UserProfile
Usually it's enough renaming/deleting the file "user/registrymodifications.xcu",  it affects all the options in Menu/Tools/Options, and the files "user/basic/dialog.xlc" and "scrip.xlc" are overwritten, additionally custom colors in "user/config/standard.soc" are lost.
Comment 5 Robert Gonzalez MX 2016-10-02 15:11:44 UTC
OK.

Renamed the user profiles of LO 5.2.2.2 and LODev 5.3.0.0.alpha0 and still I can reproduce the problem. Even the standard toolbar changes some of the icons to inactive.
Comment 6 Robert Gonzalez MX 2016-10-02 15:31:05 UTC
Tested also in Version: 5.2.0.4
Build ID: 066b007f5ebcc236395c7d282ba488bca6720265
CPU Threads: 8; OS Version: Linux 4.1; UI Render: default; 
Locale: es-MX (es_MX.UTF-8)
on OpenSuse Leap

I will update to 5.2.2.2, test and send screenshoots.
Comment 7 Robert Gonzalez MX 2016-10-02 17:10:09 UTC
Tested and reproduced with Version: 5.2.2.2
Build ID: 8f96e87c890bf8fa77463cd4b640a2312823f3ad
CPU Threads: 8; OS Version: Linux 4.1; UI Render: default; 
Locale: es-MX (es_MX.UTF-8); Calc: group
On OpenSuse Leap

Just insert a comment in any cell and then use the ESC key and see how the format toolbar changes.
Comment 8 Robert Gonzalez MX 2016-10-02 17:12:25 UTC
Created attachment 127778 [details]
Screenshot in OpenSuse Leap
Comment 9 Robert Gonzalez MX 2016-10-02 17:13:16 UTC
Created attachment 127779 [details]
Cursor screenshot in OpenSuse Leap
Comment 10 Robert Gonzalez MX 2016-10-02 17:46:11 UTC
Tested and reproduced with Version: 5.3.0.0.alpha0+
Build ID: 55c30b56ed9bfe44ab2a2a6861aa3d9ad2d16601
CPU Threads: 8; OS Version: Linux 4.1; UI Render: default; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: 2016-10-01_23:22:27
Locale: es-MX (es_MX.UTF-8); Calc: group
Comment 11 brucehohl 2016-10-08 00:36:03 UTC
I have been able to reproduce this bug in:
Windows 7 with LO 5.2.0.4
Linux 4.4 with LO 5.2.2.2

As follows:
1 Open LO and to best see bug remove all Toolbars
  View > Toolbars: Uncheck all.

2 Right click any cell, click "Insert Comment"
  "Text Formatting" tool bar appears.

3 Add test to yellow comment box; click Escape when done.
  "Text Formatting" tool bar disappears.

4 Now as long as comments exist if the users presses Escape anywhere in
  the workbook the "Text Formatting" tool bar opens/closes.
Comment 12 Robert Gonzalez MX 2016-10-30 23:31:26 UTC
Tested with LO Version: 5.3.0.0.alpha1+
Build ID: 0ebe9fab18e732468d2b9d53dddf9f266411a0e5
CPU Threads: 8; OS Version: Windows 6.2; UI Render: default; 
TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2016-10-26_17:43:20
Locale: es-MX (es_MX); Calc: group

On Windows 10 and is not present.
Comment 13 brucehohl 2016-10-31 01:44:33 UTC
Tested with: Version: 5.3.0.0.alpha1+
Build ID: 0a4e0dfffd2038c5bcaef0bc20884e60dfc2080a
CPU Threads: 2; OS Version: Linux 4.4; UI Render: default; VCL: gtk2; Layout Engine: old; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: 2016-10-30_01:41:00
Locale: en-US (en_US.UTF-8); Calc: group

On Linux and bug is not present.
Comment 14 Robert Gonzalez MX 2017-06-05 00:27:13 UTC
Hi. tested this bug with Version: 5.3.3.2 (x64)
Build ID: 3d9a8b4b4e538a85e0782bd6c2d430bafe583448
CPU Threads: 8; OS Version: Windows 6.19; UI Render: GL; Layout Engine: new; 
Locale: es-MX (es_MX); Calc: group
On Window 10 and the bug is not present anymore.
Comment 15 Robert Gonzalez MX 2017-06-05 00:33:54 UTC
Tested it also on LO Version: 5.2.6.2
Build ID: a3100ed2409ebf1c212f5048fbe377c281438fdc
CPU Threads: 8; OS Version: Windows 6.2; UI Render: GL; 
Locale: es-MX (es_MX); Calc: group
On Windows 10, and is not present.

I guess this bug could be closed as WORKSFORME.
Comment 16 QA Administrators 2018-06-06 02:46:42 UTC Comment hidden (obsolete)
Comment 17 Robert Gonzalez MX 2018-10-07 22:04:47 UTC
I retested this issue and its no longer present. Since my comment 15 I hadn't have a problem with this, so I'll change status to WORKSFORME.