Bug 103943 - FILESAVE: DOCX: Dot colours in chart are not preserved
Summary: FILESAVE: DOCX: Dot colours in chart are not preserved
Status: RESOLVED NOTABUG
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Chart (show other bugs)
Version:
(earliest affected)
5.3.0.0.alpha1+
Hardware: All All
: lowest trivial
Assignee: Not Assigned
URL:
Whiteboard: target:5.4.0
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2016-11-15 18:11 UTC by Xisco Faulí
Modified: 2016-12-01 09:22 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Xisco Faulí 2016-11-15 18:11:27 UTC
Steps to reproduce:
1. Open attachment 98675 [details]
2. Save it to .DOCX
3. Open the saved document

Observed behavior: Dot colours in chart are not preserved

author	Markus Mohrhard <markus.mohrhard@googlemail.com>	2016-09-30 22:32:28 (GMT)
committer	Markus Mohrhard <markus.mohrhard@googlemail.com>	2016-10-01 02:18:18 (GMT)
commit 74b2cc607448d24146bd3508abb832d6ab42cb56 (patch)
tree a631fc423c8ee264c974aa396efca470c131d938
parent 5f658dc87794036182aa1f8586d82c5ee997cd8b (diff)

tdf#96161, always write the varyColors element
The default value changed between MSO 2007 and 2010 so we need to always write the value.

Change-Id: I563eafa84baa3df656c83d657ebbb4c381c09957
Reviewed-on: https://gerrit.libreoffice.org/29420
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Jenkins <ci@libreoffice.org>
Comment 1 Xisco Faulí 2016-11-15 18:12:42 UTC
Adding Cc: to Markus Mohrhard
Comment 2 Markus Mohrhard 2016-11-18 10:38:42 UTC
Again a bug in the document with a missing Version element in the app.xml. Therefore the document is not recognized as MSO 2007 and we use the wrong default value.

So the document is not imported as it should be but I have now anyway improved the varyColors export.
Comment 3 Commit Notification 2016-11-30 22:35:12 UTC
Markus Mohrhard committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=ff22a22286bb4c17c3affc89d31a6c10447481c5

better varyColors export for charts, related tdf#103943

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Luke 2016-12-01 03:51:56 UTC
MS Word 2013 refuses to open attachment 98675 [details] "because it found a problem with its Contents". This bugdoc is invalid.
Comment 5 Xisco Faulí 2016-12-01 09:22:06 UTC
Hello Markus,
So is this eventually a bug? Should be fixed by ff22a22286bb4c17c3affc89d31a6c10447481c5 now? Could you please update the status accordantly?