Bug 105299 - Resizable dialogs cause maximizing in OS X full screen mode
Summary: Resizable dialogs cause maximizing in OS X full screen mode
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
4.1.4.2 release
Hardware: All macOS (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:5.4.0
Keywords:
Depends on:
Blocks: Full-Screen-Mode
  Show dependency treegraph
 
Reported: 2017-01-12 21:57 UTC by Thorsten Wagner
Modified: 2018-02-28 07:30 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Thorsten Wagner 2017-01-12 21:57:58 UTC
Description:
Resizable dialogs cause problems on OS X: In full screen mode they cover the whole display, because such windows are maximized by OS X in full screen mode. Non resizable dialogs are a prerequisite to keep LO usable in full screen mode on Macs.

Steps to Reproduce:
1. Open LibreOffice Writer
2. Maximize window to switch to full screen mode
3. Select Styles / Load Styles

Actual Results:  
Load Styles dialog becomes maximized and covers whole screen

Expected Results:
Load Styles dialog remains normal sized as like as e.g. Format / Page


Reproducible: Always

User Profile Reset: No

Additional Info:
Issue appears with LO 5.1.6 as well as with current master.


User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:50.0) Gecko/20100101 Firefox/50.0
Comment 1 Heiko Tietze 2017-01-12 23:33:37 UTC
At least the file dialog should remain resizable because of the input field, that's what we agreed on. Would be good to have a list of dialogs that should be changed.
Comment 2 Alex Thurgood 2017-01-13 08:09:36 UTC
Confirming with

Version: 5.2.3.3
Build ID: d54a8868f08a7b39642414cf2c8ef2f228f780cf
Threads CPU : 2; Version de l'OS :Mac OS X 10.12.2; UI Render : par défaut; 
Locale : fr-FR (fr_FR.UTF-8); Calc: group

Although this probelm has been around for a while.

Bug 103923 seems to be related to this report.
Comment 3 Alex Thurgood 2017-01-13 08:22:36 UTC
Full screen dialog problem already present in 

Version: 4.1.4.2
Build ID: 0a0440ccc0227ad9829de5f46be37cfb6edcf72

1) Start LO4142
2) Open a new Writer document
3) Click the green window button to enter fullscreen mode
4) Click on the Styles and Formatting button
5) Styles dialog shown fullscreen.
Comment 4 Alex Thurgood 2017-01-13 08:25:23 UTC
Possibly, this goes back even earlier, but I don't have those versions to test anymore.

For me, the problem is linked to incorrect full screen support by LO on OSX, which is addressed by a multitude of other bug reports, and for which Tor has already suggested we remove the code rather than continue to fudge it as we do currently.
Comment 5 Commit Notification 2017-02-27 12:45:14 UTC
heiko tietze committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=e8147b4b7107cc2fdb68a76deb3d30296a67434d

tdf#105299 Dialogs must not be resizable

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Heiko Tietze 2017-02-27 14:27:44 UTC
The patch makes the wizard dialog and the address template dialog non-resizable. Some dialogs are still resizable when lengthy user input is required.
Comment 7 QA Administrators 2018-02-28 03:39:11 UTC
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information from Help - About LibreOffice.
 
If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug