Bug 106225 - UI: Wrong wording/entry "Table properties..." in table context menu
Summary: UI: Wrong wording/entry "Table properties..." in table context menu
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
5.3.0.3 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:5.4.0
Keywords: difficultyBeginner, easyHack, skillUI
Depends on:
Blocks:
 
Reported: 2017-02-28 09:39 UTC by Gerald Pfeifer
Modified: 2017-05-14 07:43 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Gerald Pfeifer 2017-02-28 09:39:01 UTC
The option "Table properties..." in the table context menu leads to a
dialog "Format Cells", which is surprising/confusing.

The "Character..." and "Paragraph..." items lead to dialogs titled
"Character" and "Paragraph", respectively, so the "Table properties..."
items is indeed an outlier.

How to repeat:

 . Create an empty table on an empty slide.
 . Right click on the table.
 . Observe and invoke the "Character...", "Paragraph...", and "Table
   Properties..." menu items and the titles of the dialogs they open.

Suggestion: Align the name of the menu item and the dialog it invokes.
Comment 1 Xisco Faulí 2017-03-02 11:07:01 UTC
Confirmed in

Version: 5.4.0.0.alpha0+
Build ID: d3676ceeec55a41337ce5e6bc596f4f100d0638e
CPU threads: 4; OS: Linux 4.8; UI render: default; VCL: gtk2; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group
Comment 2 Katarina Behrens (Inactive) 2017-03-03 10:12:26 UTC
This is an easy hack

UNO command (search for TableDialog):
officecfg/registry/data/org/openoffice/Office/UI/DrawImpressCommands.xcu

.ui file for the dialog:
cui/uiconfig/ui/formatcellsdialog.ui 

Either change the label of UNO command to "Format Cells", or the dialog title in .ui file to "Table Properties". I don't care either way ...
Comment 3 Commit Notification 2017-03-27 08:25:22 UTC
Fakabbir Amin committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=41cd0ccc68b5bb43bfe28f0ece0b1fbc25a7adf3

tdf#106225 Rename Table Format to Table Properties

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Katarina Behrens (Inactive) 2017-03-27 11:24:18 UTC
So this is now fixed for Writer

@aeimi: can you also make a 2nd patch and fix for Impress/Draw (formatcellsdialog.ui in cui, not to be confused with the one in sc)
Comment 5 Fakabbir amin 2017-04-22 12:53:39 UTC
(In reply to Katarina Behrens (CIB) from comment #4)
> So this is now fixed for Writer
> 
> @aeimi: can you also make a 2nd patch and fix for Impress/Draw
> (formatcellsdialog.ui in cui, not to be confused with the one in sc)

Sure, didn't noticed the reopened tag. Will upload a patch soon.
Comment 6 Commit Notification 2017-05-09 09:44:30 UTC
Fakabbir Amin committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=428eadd39004ca22e1e87a9cbdd4cb40ebb15264

tdf#106225 Rename Table Format to Table Properties in Impress/Draw

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.