Bug 106646 - EDITING: Deleting a column in a large spreadsheet quite slow
Summary: EDITING: Deleting a column in a large spreadsheet quite slow
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
4.2.0.4 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, perf, regression
Depends on:
Blocks: Cell-Add-Delete multi_type_vector-regressions
  Show dependency tree / graph
 
Reported: 2017-03-19 18:33 UTC by Telesto
Modified: 2019-03-08 18:56 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:

Attachments
Example file (6.02 MB, application/vnd.oasis.opendocument.spreadsheet)
2017-03-19 18:38 UTC, Telesto 		Details
bibisect output in 42max repo (7.17 KB, text/plain)
2017-06-14 03:15 UTC, Terrence Enger 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2017-03-19 18:33:32 UTC 
Description:
Deleting a a column in a large spreadsheet (357000 lines) is quite slow

Steps to Reproduce:
1. Open attached file
2. Delete column B by right clicking column B and selecting 'Delete Columns'

Actual Results:  
It will take around 30 seconds to delete the column

Expected Results:
The deletion should be instantaneous (like LibO 3.0.0) or with only a small (2 sec) delay (like LibO 4.1)


Reproducible: Always

User Profile Reset: No

Additional Info:
Found in
Version: 5.4.0.0.alpha0+
Build ID: f2efe33f71a8c092a19e3a27a85ac9057ebdca64
CPU threads: 4; OS: Windows 6.19; UI render: GL; 
TinderBox: Win-x86@42, Branch:master, Time: 2017-03-18_00:11:52
Locale: nl-NL (nl_NL); Calc: CL

and in
Versie: 4.4.6.3 
Build ID: e8938fd3328e95dcf59dd64e7facd2c7d67c704d
Locale: nl_NL

and in
Versie: 4.2.0.4 
Build ID: 05dceb5d363845f2cf968344d7adab8dcfb2ba71

but only very small delay in 
Versie: 4.1.0.4 
Build ID: 89ea49ddacd9aa532507cbf852f2bb22b1ace28


User-Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:45.0) Gecko/20100101 Firefox/45.0
Comment 1 Telesto 2017-03-19 18:38:22 UTC 
Created attachment 132016 [details]
Example file
Comment 2 m_a_riosv 2017-03-20 00:43:26 UTC 
Reproducible.
Version: 5.3.1.2 (x64)
Build ID: e80a0e0fd1875e1696614d24c32df0f95f03deb2
CPU Threads: 4; OS Version: Windows 6.19; UI Render: default; Layout Engine: new; 
Locale: es-ES (es_ES); Calc: group
Comment 3 m_a_riosv 2017-03-20 00:53:58 UTC 
Looks the issue is in relation with the direct format as 'Text' @ on the first column.
Comment 4 m_a_riosv 2017-03-20 00:55:51 UTC 
Using a cell style instead a direct format seems to work fine.
Comment 5 Terrence Enger 2017-06-14 03:15:26 UTC 
Created attachment 134009 [details]
bibisect output in 42max repo

Working on debian-stretch in the bibisect-42max repository, I see that
the slowness entered LO somewhere in the 43 commits to master ...

          commit    s-h
          --------  --------
    good  690230ca  ac84ffb3
    bad   8e7bade4  4c99a427

The fast deletions of column B took 4 to 7 CPU seconds; the slow
deletions which I let run to completion took 8 and a fraction CPU
minutes.

I am setting keyword bibisected and removing bibisectRequest.
Comment 6 Terrence Enger 2017-06-17 01:06:25 UTC 
Bug 108347 entered LibreOffice in the same range of commits.  I am not
concluding that these are duplicates, but a fix to either is a good
reason to retest the other,
Comment 7 Telesto 2017-06-19 13:50:52 UTC 
Because it's probably another facet of this bug I'm reporting it here:
1. Open Calc
2. Insert 600 sheets
3  Select all sheet (except one) and delete they rest -> slow with 4.2.0.4 and up. In 9 seconds with 4.1.0.4
Comment 9 QA Administrators 2019-02-23 03:41:48 UTC Comment hidden (obsolete)
Comment 10 Terrence Enger 2019-03-08 18:56:42 UTC 
Working on debian-buster in latest commit in bibisect-linux-64-6.3
(commit e85e3866), deletion of column B took 0.80 CPU seconds.

I am setting status RESOLVED WORKSFORME.