Bug 106731 - No indication macro is read-only
Summary: No indication macro is read-only
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: BASIC (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium enhancement
Assignee: Rafael Lima
URL:
Whiteboard: target:7.6.0
Keywords:
Depends on:
Blocks: Error-Messages
  Show dependency treegraph
 
Reported: 2017-03-23 21:49 UTC by Katarina Behrens (Inactive)
Modified: 2023-01-16 11:29 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Katarina Behrens (Inactive) 2017-03-23 21:49:02 UTC
Description:
I can't believe this hasn't been filed yet, but I haven't found any related ticket, so here we go:

Steps to Reproduce:
1. Tools > Macros > Organize Macros > Libreoffice Basic
2. Click 'Libreoffice Macros' in the tree-list on the left 
3. In the same tree-list, pick a macro from any of those system-wide modules, for example Gimmicks.Autotext 

(it is important to try with system-wide macros and not with user-defined or document-specific ones, otherwise you won't see the misfeature)

4. Click 'Edit'
5. Try to edit the source code



Actual Results:  
Nothing happens. Macro is read-only. That wouldn't be an issue, but user really has no way of knowing that this is the case.

Expected Results:
A yellow-ish info bar ("this document is read-only") would appear, just like for normal documents. Or it would be indicated in another suitable way that it is futile to try to edit this macro


Reproducible: Always

User Profile Reset: 

Additional Info:


User-Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:47.0) Gecko/20100101 Firefox/47.0
Comment 1 Cor Nouws 2017-03-23 22:01:36 UTC
yeah, cool, isn't it ;)
Comment 2 Rafael Lima 2023-01-11 14:59:54 UTC
Proposed patch here:
https://gerrit.libreoffice.org/c/core/+/145307

With this patch the Basic IDE will inform that a read-only module/dialog is read-only in two ways:
1) In the status bar, after the module/dialog name by adding a "(Read-only") string to the name
2) When an alphanum key is pressed in the code editor (the message appears only in the first time per module)
Comment 3 Commit Notification 2023-01-16 11:29:00 UTC
Rafael Lima committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/d466df5bc220eb80b8a51ff64507de881b938ed3

tdf#106731 Warn user that a module/dialog is read-only in Basic IDE

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.