Bug 106898 - Flash during slide transition with GTK VCL plugin (not with GTK3)
Summary: Flash during slide transition with GTK VCL plugin (not with GTK3)
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
5.1.0.0.alpha1
Hardware: All Linux (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:6.0.0
Keywords: bibisected, regression
Depends on:
Blocks: VCL-Scheduler Slide-Transitions GTK2
  Show dependency treegraph
 
Reported: 2017-03-31 13:24 UTC by Aron Budea
Modified: 2019-03-01 19:06 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Empty presentation with single Checkers slide transition (12.00 KB, application/vnd.oasis.opendocument.presentation)
2017-03-31 13:24 UTC, Aron Budea
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Aron Budea 2017-03-31 13:24:24 UTC
Created attachment 132297 [details]
Empty presentation with single Checkers slide transition

The attached presentation is an empty file with Checkers slide transition on the slide.
Open and play it (if your Impress is compiled with GTK3 support, start as: "SAL_USE_VCLPLUGIN=gtk ./soffice --impress").

About 1/3 way through there is a white flash.

Observed with v5.1.0.3, 5.3.1.2, 5.4 master build / Ubuntu 16.04.
Not reproducible with v5.0.0.5. => regression

There is a bit of resemblance to bug 95479 and bug 99685, but they don't seem to be related.
Comment 1 Xisco Faulí 2017-03-31 15:34:02 UTC
Regression introduced in range: https://cgit.freedesktop.org/libreoffice/core/log/?qt=range&q=ba90813d17cf35cfb67585d6f119d3ddb30f5978..fe88fe6f828597fe2645a20c1a07716216a810c3

bibisected with lo-linux-dbgutil-daily-till51
Comment 2 Aron Budea 2017-04-16 16:22:40 UTC
Interestingly I don't get a flash at that point in the bibisect repo, so I looked further, and the range for me is this:
https://cgit.freedesktop.org/libreoffice/core/log/?qt=range&q=41379970e8c6b75563b7c162b4e760b9e93a5bea..3a906cedeb700ffb950b46e728b20676956cec72
(2015-11-14: source-hash-3a906cedeb700ffb950b46e728b20676956cec72)
Comment 3 Aron Budea 2017-04-16 16:35:05 UTC
(In reply to Xisco Faulí from comment #1)
> Regression introduced in range:
> https://cgit.freedesktop.org/libreoffice/core/log/
> ?qt=range&q=ba90813d17cf35cfb67585d6f119d3ddb30f5978..
> fe88fe6f828597fe2645a20c1a07716216a810c3
> 
> bibisected with lo-linux-dbgutil-daily-till51

As I noted in bug 99685, I get this range if I bibisect that issue.
I would assume the issues are different, though.
Comment 4 Kevin Suo 2017-12-21 04:06:53 UTC
Removing keyword bibisectRequest as it's already bibisected.
Comment 5 Aron Budea 2019-03-01 17:30:48 UTC
Works in 6.2.0.3, since 6.0.0.3 / Ubuntu 18.04.
It was still buggy in 5.4.0.3.

=> Closing as WFM.
Comment 6 Aron Budea 2019-03-01 19:06:34 UTC
Reverse-bibisected the fixed behavior to the following commit. Nice fix, Jan-Marek!

https://cgit.freedesktop.org/libreoffice/core/commit/?id=52dfefec8da5d7f25c39218fd890cad6491728ab
author		Jan-Marek Glogowski <glogow@fbihome.de>	2017-01-27 23:40:11 +0100
committer	Jan-Marek Glogowski <glogow@fbihome.de>	2017-07-13 12:10:27 +0200

Run LO scheduler only via system timer