Bug 107182 - Starting in safe mode - in safe mode options dalog the same button (apply changes and restart) appears twice
Summary: Starting in safe mode - in safe mode options dalog the same button (apply cha...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
5.3.2.2 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:5.3.3
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-15 13:31 UTC by bordfeldt
Modified: 2017-04-19 12:22 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
safe mode options dialog - button appears twice (193.45 KB, image/jpeg)
2017-04-15 13:31 UTC, bordfeldt
Details

Note You need to log in before you can comment on or make changes to this bug.
Description bordfeldt 2017-04-15 13:31:23 UTC
Created attachment 132586 [details]
safe mode options dialog - button appears twice

fresh install of LO 5.3.2.2 on Windows 10 Pro

Starting in safe mode the "apply changes and restart"-button appears twice. One time in german and one time in english. See attached screenshot.
Comment 1 Xisco Faulí 2017-04-17 10:56:16 UTC
I can reproduce it in

Versión: 5.3.2.2
Id. de compilación: 6cd4f1ef626f15116896b1d8e1398b56da0d0ee1
Subproc. CPU: 1; SO: Windows 6.1; Repr. de IU: predet.; Motor de trazado: HarfBuzz; 
Configuración regional: es-ES (es_ES); Calc: group
Comment 2 Xisco Faulí 2017-04-17 11:01:57 UTC
Reproduced in

Versió: 5.3.2.2
ID de la construcció: 1:5.3.2~rc2-0ubuntu1~yakkety0
Fils de CPU: 4; Versió de SO: Linux 4.8; Renderitzador de la IU: per defecte; VCL: gtk3; Motor de traçat: nou; 
Configuració local: ca-ES (ca_ES.UTF-8); Calc: group
Comment 3 Katarina Behrens (Inactive) 2017-04-18 14:05:18 UTC
So this looks like a mismatch of widget ids and respective translations (in .po files) because some1 backported my commit https://cgit.freedesktop.org/libreoffice/core/commit/?id=2b60861a84b3e28cc110110e762fba5d6fbc43dd to fix more serious bug (some crasher iirc), but obviously the translations ain't updated accordingly yet.

But according to https://cgit.freedesktop.org/libreoffice/translations/commit/?id=769636b6ac5701c4378d685440fed2e1f968f4bc this should be okay in 5.3.3 again
Comment 4 Katarina Behrens (Inactive) 2017-04-18 14:09:30 UTC
Maybe not for all languages, but certainly for German and Spanish ... I dunno if I can close this bug as fixed then, I'll leave that decision to you QA people
Comment 5 Adolfo Jayme Barrientos 2017-04-19 12:22:47 UTC
AFAICT this can be closed, as after seeing the commit in the translations repo it seems that all the IDs are now in sync again, even if there aren’t translations for all the languages.

Thanks for tracking down the cause of the bug, Katarina =)