as I need for each request a bug report. this is the generic bug report for missing icons. Some actions are missing icons there are some reason for this 1. no icon is available 2. no icon is needed, because the action wasn't used in a toolbar so I'd like to discuss here if 1 or 2 isn't correct any more.
Created attachment 132702 [details] missing icons for the toolbar Missing icon for the actions - findbar (open the find toolbar when click on it) - pagedialog (all dialog actions in the format setting has an icon so why not pagedialog. in addition I use this action in the uploaded screenshot - update all (icon is available and I use the action, so I need an icon for it)
andreas kainz committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=b1cd3eebf74345d18b47d2de0d4d0e81ef0d7b96 tdf#107277 add update all icon for writer menu It will be available in 5.4.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Just for the record - no need to accompany every commit with a bug report if the change is obvious from the commit summary :-) A commit like: ----- 8< ----- Add icons for X, Y, and Z The icons were not needed so far, because the actions were not available in the toolbar previously. ----- 8< ----- is perfectly fine, and does not need a bugreport. Creating bugreports for ~trivial stuff by commiters themselves just means lots of unnecessary work, and general "catch all" bugreports make no sense either.
Moving to NEW as there's already a commit for this bug
andreas kainz committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=93b500ee7c1cbb141bb77b94054f3bee9c3b510a tdf#107277 add findbar and pagedialog icon to writer It will be available in 5.4.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Hello, Is this bug fixed? If so, could you please close it as RESOLVED FIXED?