Bug 107464 - Crash when spell checking text in draw objects
Summary: Crash when spell checking text in draw objects
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
5.4.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:5.4.0
Keywords: bibisectRequest, regression
: 107803 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-04-26 23:02 UTC by Thomas Lendo
Modified: 2017-05-13 10:40 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot of error message (8.82 KB, image/png)
2017-04-27 10:21 UTC, Regina Henschel
Details
Example file (10.23 KB, application/3dr)
2017-04-27 17:16 UTC, Telesto
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Lendo 2017-04-26 23:02:21 UTC
Steps to reproduce the crash:

1. Open Writer or Draw.
2. (Activate and) Go to the Drawing toolbar.
3. Insert a drawing object which can contain text.
4. Insert a dummy text into the drawing object which is complained by the spell checker.
5. Right-click on the red underlined text in the drawing object.

Actual result:
Crash.

The fatal error message shows the text:
{path}/LibreOfficeDev_5.4.0.0.alpha0_Linux_x86_deb/DEBS/install/opt/libreofficedev5.4/program/../share/config/soffice.cfg/editeng/ui/spellmenu.ui
Comment 1 Thomas Lendo 2017-04-26 23:08:08 UTC
Version: 5.4.0.0.alpha0+
Build ID: 1167df7df59e37fddef0c40c4d27cb2e82e10922
CPU threads: 2; OS: Linux 3.13; UI render: default; VCL: gtk2; 
TinderBox: Linux-rpm_deb-x86@71-TDF, Branch:master, Time: 2017-04-26_14:55:28
Locale: de-DE (de_DE.UTF-8); Calc: group
Ubuntu Linux 14.04 LTS
AdapterDeviceId=Gallium 0.4 on NV86
AdapterVendorId=nouveau
UseOpenGL=false
Comment 2 Xisco Faulí 2017-04-27 08:24:21 UTC
I can't reproduce it in

Version: 5.4.0.0.alpha0+
Build ID: 7c11fe076005ed4e28f04f14990b7011a03a4517
CPU threads: 4; OS: Linux 4.8; UI render: default; VCL: gtk2; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group
Comment 3 Regina Henschel 2017-04-27 10:21:22 UTC
Created attachment 132888 [details]
Screenshot of error message

Crash reproduced with Version: 5.4.0.0.alpha0+
Build ID: a917902c48f21d04039da86048c5c36555137d7e
CPU threads: 4; OS: Windows 6.1; UI render: default; 
TinderBox: Win-x86@62-TDF, Branch:MASTER, Time: 2017-04-24_23:35:22
Locale: de-DE (de_DE); Calc: group

The same crash happens on right click on a misspelled word in comments.
Comment 4 Regina Henschel 2017-04-27 10:35:54 UTC
It was OK in Version: 5.4.0.0.alpha0+
Build ID: 0cd819b68ced2a95a127a246c0558153fbdbcae2
CPU Threads: 4; OS Version: Windows 6.1; UI Render: default; 
TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2017-01-31_12:28:03
Locale: de-DE (de_DE); Calc: group

It crashes in Version: 5.4.0.0.alpha0+
Build ID: eb7b03b052ffe8c2c577b2349987653db6c53f76
CPU threads: 4; OS: Windows 6.1; UI render: default; 
TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2017-02-26_22:34:18
Locale: de-DE (de_DE); Calc: group
Comment 5 Xisco Faulí 2017-04-27 11:16:53 UTC
(In reply to Regina Henschel from comment #4)
> It was OK in Version: 5.4.0.0.alpha0+
> Build ID: 0cd819b68ced2a95a127a246c0558153fbdbcae2
> CPU Threads: 4; OS Version: Windows 6.1; UI Render: default; 
> TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2017-01-31_12:28:03
> Locale: de-DE (de_DE); Calc: group
> 
> It crashes in Version: 5.4.0.0.alpha0+
> Build ID: eb7b03b052ffe8c2c577b2349987653db6c53f76
> CPU threads: 4; OS: Windows 6.1; UI render: default; 
> TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2017-02-26_22:34:18
> Locale: de-DE (de_DE); Calc: group

Hi Regina,

Could you please check if the crash in the comment is not the same as bug 106159?
Do you still reproduce it with a recent master build ?
OTOH, Can you reproduce Thomas' bug ?
Comment 6 Regina Henschel 2017-04-27 13:00:45 UTC
(In reply to Xisco Faulí from comment #5)
> Could you please check if the crash in the comment is not the same as bug
> 106159?
It is not the same, because bug 106159 is a crash in the Navigator.

> Do you still reproduce it with a recent master build ?
Yes, still in Version: 5.4.0.0.alpha0+
Build-ID: 597a2f5d5bd37443262b0775b8439bc3502aef1b
CPU-Threads: 4; BS-Version: Windows 6.1; UI-Render: Standard; 
TinderBox: Win-x86@62-TDF, Branch:MASTER, Time: 2017-04-26_22:29:37
Gebietsschema: de-DE (de_DE); Calc: group

> OTOH, Can you reproduce Thomas' bug ?
Yes, it crashes e.g. in a text box or a custom shape callout. And it crashes in a comment as well. I wonder, why you cannot reproduce the crash. What build is yours? I cannot find your build ID.
Comment 7 Xisco Faulí 2017-04-27 16:44:53 UTC
(In reply to Regina Henschel from comment #6)
> (In reply to Xisco Faulí from comment #5)
> > Could you please check if the crash in the comment is not the same as bug
> > 106159?
> It is not the same, because bug 106159 is a crash in the Navigator.
> 
> > Do you still reproduce it with a recent master build ?
> Yes, still in Version: 5.4.0.0.alpha0+
> Build-ID: 597a2f5d5bd37443262b0775b8439bc3502aef1b
> CPU-Threads: 4; BS-Version: Windows 6.1; UI-Render: Standard; 
> TinderBox: Win-x86@62-TDF, Branch:MASTER, Time: 2017-04-26_22:29:37
> Gebietsschema: de-DE (de_DE); Calc: group
> 
> > OTOH, Can you reproduce Thomas' bug ?
> Yes, it crashes e.g. in a text box or a custom shape callout. And it crashes
> in a comment as well. I wonder, why you cannot reproduce the crash. What
> build is yours? I cannot find your build ID.

Sorry, I had a local commit. my build was updated tonight over night. ID: 597a2f5d5bd37443262b0775b8439bc3502aef1b. Still, I can't reproduce it
Comment 8 Telesto 2017-04-27 17:16:42 UTC
Created attachment 132916 [details]
Example file

Repro with:
Version: 5.4.0.0.alpha0+
Build ID: 597a2f5d5bd37443262b0775b8439bc3502aef1b
CPU threads: 4; OS: Windows 6.2; UI render: default; 
TinderBox: Win-x86@62-TDF, Branch:MASTER, Time: 2017-04-26_22:29:37
Locale: nl-NL (nl_NL); Calc: CL
Comment 9 Regina Henschel 2017-04-27 17:49:52 UTC
(In reply to Xisco Faulí from comment #7)
> Sorry, I had a local commit. my build was updated tonight over night. ID:
> 597a2f5d5bd37443262b0775b8439bc3502aef1b. Still, I can't reproduce it

Which language packs do you have installed? I have installed en-US and de in all tested cases.
Comment 10 Xisco Faulí 2017-04-27 20:45:06 UTC
I can't reproduce it with the attached document neither.
I use es, ca and en-GB as built languages
Comment 11 Regina Henschel 2017-04-27 21:11:49 UTC
@Xisco: I use the build from http://dev-builds.libreoffice.org/daily/master/Win-x86@62-TDF/ including the en-US and de helppack. I see neither ca nor en-GB dictionary in that build. Do you have an own build? If yes, please try one from TDF.

I use the 32-bit version. You too?
Comment 12 Xisco Faulí 2017-04-28 12:24:40 UTC
(In reply to Regina Henschel from comment #11)
> @Xisco: I use the build from
> http://dev-builds.libreoffice.org/daily/master/Win-x86@62-TDF/ including the
> en-US and de helppack. I see neither ca nor en-GB dictionary in that build.
> Do you have an own build? If yes, please try one from TDF.
> 
> I use the 32-bit version. You too?

Ok, I can reproduce it in

Version: 5.4.0.0.alpha0+
Build ID: 74ccd02eda2d6325a27266fd935aba29b3d75020
CPU threads: 1; OS: Windows 6.1; UI render: default; 
TinderBox: Win-x86@62-TDF, Branch:MASTER, Time: 2017-04-28_00:28:06
Locale: es-ES (es_ES); Calc: group
Comment 13 Xisco Faulí 2017-04-28 12:28:39 UTC
This is the affected file https://cgit.freedesktop.org/libreoffice/core/tree/editeng/uiconfig/ui/spellmenu.ui which was recently added by Caolán -> https://cgit.freedesktop.org/libreoffice/core/commit/?id=5d6a605a698239638e0a1282e3e99a704b7f3654 However I can't check whether this commit introduced the regression...
Comment 14 Caolán McNamara 2017-04-29 20:01:58 UTC
I think its not getting packed into the .msi file (or rpm/deb) but is present in the instdir of a build, which is why it works in a self-build
Comment 15 Commit Notification 2017-04-29 20:47:47 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=3a8e111fa3ed538018de98ac3a6a480555e7b204

tdf#107464 editeng ui files not packed in install sets

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 16 Caolán McNamara 2017-04-29 20:57:21 UTC
I think that'll do it
Comment 17 Thomas Lendo 2017-05-11 23:15:18 UTC
Caolán, thank you. Looks good.

Version: 5.4.0.0.alpha1+
Build ID: f6fd7dd08b478857234a3b1b5b18e65e9b250174
CPU threads: 4; OS: Linux 4.8; UI render: default; VCL: gtk2; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: 2017-05-11_08:26:56
Locale: de-DE (de_DE.UTF-8); Calc: group
Comment 18 Xisco Faulí 2017-05-13 10:40:35 UTC
*** Bug 107803 has been marked as a duplicate of this bug. ***