Bug 107629 - Ctrl+Leftshift/Rightshift shortcut keys function but are not listed in keyboard shortcuts
Summary: Ctrl+Leftshift/Rightshift shortcut keys function but are not listed in keyboa...
Status: RESOLVED DUPLICATE of bug 103158
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
(earliest affected) release
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: Not Assigned
Depends on:
Reported: 2017-05-04 15:54 UTC by Kiarash Korki
Modified: 2017-09-08 03:01 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Note You need to log in before you can comment on or make changes to this bug.
Description Kiarash Korki 2017-05-04 15:54:57 UTC
When typing a paragraph pressing Ctrl+LeftShift changes the paragraph direction to left-to-right and pressing Ctrl+RightShift changes the paragraph direction to right-to-left. But these two key combinations are not included in keyboard shortcuts list and thus cannot be disabled.

Steps to Reproduce:
1. Open a new empty document.
2. Write some words.
3. Press Ctrl+RightShift to change paragraph direction to RTL.
4. Press Ctrl+LeftShift to change paragraph direction back to LTR.
5. Use Menu -> Tools -> Customize... to open customization dialog.
6. Select Keyboard tab.

Actual Results:  
Ctrl+LeftShift and Ctrl+RightShift shortcuts are not present in shortcut keys list.

Expected Results:
Ctrl+LeftShift and Ctrl+RightShift shortcuts must be present in the list because they function.

Reproducible: Always

User Profile Reset: Yes

Additional Info:

User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:53.0) Gecko/20100101 Firefox/53.0
Comment 1 Maxim Monastirsky 2017-05-05 12:38:38 UTC
Ctrl+Shift are modifier keys, and can't be listed as keyboard shortcuts. But I guess this is about the same problem as in Bug 103158. Ctrl+Shift should change the paragraph direction when you release the key, not when you press. That way they won't conflict with other Ctrl+Shift+something shortcuts.

*** This bug has been marked as a duplicate of bug 103158 ***
Comment 2 Nadav Har'El 2017-05-05 13:19:33 UTC
I don't think this is a duplicate of that bug. That bug talks about when the action takes place - when pressing or releasing ctrl-rightshift.
But what if the user presses ctrl-rightshift and changes his mind? What can he do to avoid this silly paragraph direction change which - let me tell you as a RTL writer - nobody wants?
I think the creator of this issue has a point - just like people can disable keyboard shortcuts they don't like, it should be possible to disable this shortcut as well.
Comment 3 Maxim Monastirsky 2017-05-05 13:46:48 UTC
(In reply to Nadav Har'El from comment #2)
> What can
> he do to avoid this silly paragraph direction change which - let me tell you
> as a RTL writer - nobody wants?
And yet this is a standard shortcut in Windows and MS Word, as was also in all versions of OpenOffice.org and LibreOffice and their derivatives since 2002, and no one ever complained. Moreover when this was totally broken in 5.1, we actually got a bug report about this - see Bug 96739. So saying that "nobody wants" it, is not accurate...
Comment 4 Phant 2017-09-08 03:01:28 UTC
This is not a duplicate, though.  103158 is about inconsistent behavior about keydown vs keyup on this keyboard shortcut.  

107629 is about whether this particular keyboard shortcut should be impossible to remap.

I don't see any compelling reason why it ought to be impossible to change by the user.  Certainly being a "standard shortcut" is not a criteria for that, as it is entirely possible to remap ctrl+C and ctrl+V in libreoffice, which are far more "standard" and commonly used shortcuts (for instance, they're respected in notepad, but control+leftshift and control+rightshift are not).

What makes control+shift deserve immunity from remapping?

I can understand if it would be difficult (and thus, lower priority), but the control+shift combination can already be enabled and disabled in-program.  The way to enable or to disable the hotkey is by going through "Tools->Options->Language Settings->Languages->Default Languages for Documents, then unchecking a box labelled Complex Text Layout (CTL).

It's *really* bad UI, because there's no indication whatsoever in the program itself that this hotkey exists, or is toggled through that series of actions.  At the bare minimum the key combination should be consistently documented together with the other ones on the list of hotkeys, not buried in https://help.libreoffice.org/Common/Languages_Using_Complex_Text_Layout .