Bug 108040 - Watermark: Document modification flag is set when opening the Insert menu
Summary: Watermark: Document modification flag is set when opening the Insert menu
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.0.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Szymon Kłos
URL:
Whiteboard: target:5.5.0 target:5.4.0.1
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2017-05-23 21:10 UTC by Maxim Monastirsky
Modified: 2017-05-24 20:53 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Maxim Monastirsky 2017-05-23 21:10:01 UTC
Steps to reproduce:

1. Open a new Writer document.
2. If not under gtk3 and/or Unity - open the Insert menu.

Notice that the document is now considered modified, i.e. the save button has a star, and trying to close the document will ask for saving changes.

The problem became visible after https://cgit.freedesktop.org/libreoffice/core/commit/?id=c9c0aefd24c3aab24403b41b601c392267c6aff7
Comment 1 Xisco Faulí 2017-05-23 21:29:20 UTC
Moving to new as the problematic commit has been identified.
Comment 2 Commit Notification 2017-05-24 11:04:05 UTC
Szymon Kłos committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=6e01993a420912ab8896879b0b91c47c3479c239

tdf#108040 Don't turn on header to check if Watermark exist

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 Commit Notification 2017-05-24 12:22:53 UTC
Szymon Kłos committed a patch related to this issue.
It has been pushed to "libreoffice-5-4":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=a61d03c2fffc882a8619e293034f1432b4099de4&h=libreoffice-5-4

tdf#108040 Don't turn on header to check if Watermark exist

It will be available in 5.4.0.1.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Maxim Monastirsky 2017-05-24 20:53:45 UTC
Thank you Szymon for the quick fix!