Bug 108244 - Cell Comments Often Loss when Saving in FODS Format. Steps to reproduce in comment 5
Summary: Cell Comments Often Loss when Saving in FODS Format. Steps to reproduce in co...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
4.2.0.4 release
Hardware: x86-64 (AMD64) All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisectRequest, regression
Depends on:
Blocks: ODF-Flat
  Show dependency treegraph
 
Reported: 2017-05-30 12:28 UTC by John Carlson
Modified: 2019-06-20 14:46 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Spreadsheet with two cells with comments (7.73 KB, application/vnd.oasis.opendocument.spreadsheet)
2017-05-30 12:31 UTC, John Carlson
Details

Note You need to log in before you can comment on or make changes to this bug.
Description John Carlson 2017-05-30 12:28:09 UTC
Description:
If an existing ODS file with cell comments is saved in FODS format most of the time all or some of the cell comments will be lost.

Steps to Reproduce:
1.Create ODS file with multiple cell comments 
2.Save ODS file
3.Save as FODS file
4.Reload FODS and check for lost cell comments

Actual Results:  
In many cases, some or all of the cell comments will be lost.

Expected Results:
Expected cell comments to be maintained


Reproducible: Sometimes

User Profile Reset: Yes

Additional Info:


User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:54.0) Gecko/20100101 Firefox/54.0
Comment 1 John Carlson 2017-05-30 12:31:11 UTC
Created attachment 133723 [details]
Spreadsheet with two cells with comments

I have added a test case to demonstrate the issue.
Comment 2 m.a.riosv 2017-05-30 15:39:00 UTC
Reproducible with:
Version: 5.2.7.1
Build ID: bf0fa7b86c7c0592941ede29fca6fafff642a948
CPU Threads: 4; OS Version: Windows 6.2; UI Render: GL; 
Locale: es-ES (es_ES); Calc: group

But works fine with:
Version: 5.3.3.2 (x64)
Build ID: 3d9a8b4b4e538a85e0782bd6c2d430bafe583448
CPU Threads: 4; OS Version: Windows 6.19; UI Render: GL; Layout Engine: new; 
Locale: es-ES (es_ES); Calc: group

Please update you LibreOffice version as 5.2 is EOL there won't be new patches in it.
Comment 3 John Carlson 2017-05-30 18:58:04 UTC
I can still reproduce the issue with 5.3.3.2 on Linux.  Perhaps it is my setup.
Comment 4 m.a.riosv 2017-05-31 08:23:16 UTC
Please try resetting the user profile, sometimes solves strange issues.
https://wiki.documentfoundation.org/UserProfile
Usually it's enough renaming/deleting the file "user/registrymodifications.xcu",  it affects all the options in Menu/Tools/Options, and the files "user/basic/dialog.xlc" and "scrip.xlc" are overwritten, additionally custom colors in "user/config/standard.soc" are lost.
Comment 5 John Carlson 2017-05-31 14:25:07 UTC
The issue is my how to reproduce is wrong.

Try this:

(1) Open the attached test case
(2) Save file in FODS format
(3) Close spreadsheet
(4) Reopen file in FODS format.

You should see the comments are missing.

I've tried this on two different Debian based Linux distributions.

Assuming that this is now reproducible, do I need to open a new bug as the original write-up is invalid?
Comment 6 Telesto 2017-06-10 15:19:55 UTC
Repro with:
Version: 5.5.0.0.alpha0+
Build ID: 076ed447f694239d5c67adee528ea6e471d909ff
CPU threads: 4; OS: Windows 6.19; UI render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2017-06-09_23:54:20
Locale: nl-NL (nl_NL); Calc: CL
Comment 7 QA Administrators 2018-06-11 02:34:39 UTC Comment hidden (obsolete)
Comment 8 Xavier Van Wijmeersch 2018-06-11 08:26:48 UTC
cannot reproduce with

Version: 5.3.7.2
Build ID: 6b8ed514a9f8b44d37a1b96673cbbdd077e24059
CPU Threads: 8; OS Version: Linux 4.14; UI Render: default; VCL: kde4; Layout Engine: new; 
Locale: nl-BE (en_US.UTF-8); Calc: group

Version: 5.4.8.0.0+
Build ID: cc68977f1be22ac0f4a15eb37e05ccba13a7a554
CPU threads: 8; OS: Linux 4.14; UI render: default; VCL: kde4; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:libreoffice-5-4, Time: 2018-05-12_11:32:19
Locale: nl-BE (en_US.UTF-8); Calc: group

Version: 6.2.0.0.alpha0+
Build ID: 7d521a85858bacdb7b5db359036ccf6f01b709c3
CPU threads: 8; OS: Linux 4.14; UI render: default; VCL: kde4; 
Locale: nl-BE (en_US.UTF-8); Calc: group threade
Comment 9 John Carlson 2018-06-12 00:07:18 UTC
The problem still occurs for me.  

Version: 5.4.7.2
Build ID: c838ef25c16710f8838b1faec480ebba495259d0
CPU threads: 4; OS: Linux 4.4; UI render: default; VCL: kde4; 
Locale: en-US (en_US.UTF-8); Calc: group

The steps to reproduce this issue must be very precise.
1)  Load LibreOffice
2)  Load the testcase file.
3)  Do *not* save the file in the ODS format first.
4)  *Do* save the file in the FODS format.
5)  Close the file.
6)  Open the FODS file.

In my testing today, I find that saving the file first in the ODS format will cause the comments to be stored in the FODS *but* if the FODS file is further modified and saved the comments will be lost.

The problem also appears to be reproducible in

Version: 6.0.4.2
Build ID: 9b0d9b32d5dcda91d2f1a96dc04c645c450872bf
CPU threads: 4; OS: Linux 4.4; UI render: default; VCL: kde4; 
Locale: en-US (en_US.UTF-8); Calc: group

[it's unfortunate that my comment #1 does not have the correct steps to reproduce ... these are in comment #5]
Comment 10 Xavier Van Wijmeersch 2018-06-12 06:16:50 UTC
following the steps in comment9 i reproduce the steps

Version: 6.2.0.0.alpha0+
Build ID: b292a27698e85fd9d60c03613c3b0c67835c4dc1
CPU threads: 8; OS: Linux 4.14; UI render: default; VCL: kde4; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: 2018-06-07_02:03:56
Locale: nl-BE (en_US.UTF-8); Calc: group threaded
Comment 11 Xavier Van Wijmeersch 2018-06-12 06:19:48 UTC
following the steps in comment9 i reproduce the steps in comment10

i mean 
following the steps in comment9 i can reproduce the problem
Comment 12 QA Administrators 2019-06-13 03:01:22 UTC Comment hidden (obsolete)
Comment 13 John Carlson 2019-06-19 15:02:10 UTC
Using the "very precise" instructions in Comment #9, the problem still occurs using:

Version: 6.2.4.2
Build ID: 2412653d852ce75f65fbfa83fb7e7b669a126d64
CPU threads: 4; OS: Linux 4.4; UI render: default; VCL: kde4; 
Locale: en-US (en_US.UTF-8); UI-Language: en-US
Calc: threaded

I *thought* the first time I tried it that it worked, but it has failed consistently since then (this includes restarting the program multiple times).
Comment 14 John Carlson 2019-06-19 17:12:41 UTC
I can **NOT** reproduce the issue in Version 4.0.0.1 (Build ID: 527dba6f6e0cfbbc71bd6e7b88a52699bb48799).
Comment 15 raal 2019-06-20 12:57:22 UTC
repro Version: 4.2.0.0.alpha1+
Build ID: fc8f44e82de4ebdd50ac5fbb9207cd1a59a927e3
Comment 16 raal 2019-06-20 14:46:37 UTC
note: unable to bisect with bibisect-42max,lots of skipped commits