Bug 108439 - Update bundled spellchecker for gd
Summary: Update bundled spellchecker for gd
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Linguistic (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium normal
Assignee: Aron Budea
QA Contact:
URL:
Whiteboard: target:6.0.0 target:5.4.0
Keywords:
Depends on:
Blocks: Dictionaries
  Show dependency treegraph
 
Reported: 2017-06-10 12:38 UTC by Michael Bauer
Modified: 2017-07-05 09:38 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
version 3.3 (989.47 KB, application/vnd.openofficeorg.extension)
2017-06-10 12:38 UTC, Michael Bauer
Details
oxt for gd-GB (942.73 KB, application/vnd.openofficeorg.extension)
2017-06-12 20:13 UTC, Michael Bauer
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Bauer 2017-06-10 12:38:37 UTC
Created attachment 133942 [details]
version 3.3

Please update the Scottish Gaelic (gd) spellchecker bundled with LO to the latest version (3.3) which is attached.
Comment 1 Xisco Faulí 2017-06-10 15:08:44 UTC Comment hidden (obsolete)
Comment 2 Xisco Faulí 2017-06-11 14:34:27 UTC
@Buovjaga, Do you know who can update it ?
Comment 3 Aron Budea 2017-06-11 19:09:49 UTC
I'll take care of it.
Comment 4 Aron Budea 2017-06-11 19:19:36 UTC
Michael, the directory structure is still the old one. Based on bug 100533 I thought it would be updated, could you please check?
Comment 5 Michael Bauer 2017-06-12 20:13:19 UTC
Created attachment 133982 [details]
oxt for gd-GB

Sorry, seems I forgot to update that part of the code from the repo. Re-ran it, I think this should be in the right format?
Comment 6 Aron Budea 2017-06-16 03:57:16 UTC
Yes, looks good, I'll try to get it done during the weekend.
Comment 8 Aron Budea 2017-06-23 23:38:48 UTC
I had to make manual changes in the end, as the second archive had missing content, so I put them together from the original, plus edited the .xcu file manually.

Michael, there's an additional change I have to ask for the future, please change "en" to "en-US" in description.xml like this (to make the string automatically be picked up for translation, it's been updated in LO repo, let's not risk reverting it by an overwrite in the future):

<name lang="en-US">Scottish Gaelic spell checker</name>

Update is already in master, for 5.4 the changes are in gerrit.
Comment 9 Michael Bauer 2017-06-24 12:32:40 UTC
Wait, what missing content are we talking about?
Comment 10 Aron Budea 2017-06-24 14:24:36 UTC
In the second attachment description.xml, dictionaries.xcu and the META-INF directory were empty. Those are what I pulled from the original, and updated the location in dictionaries.xcu, since the original had the dictionary files in the subdirectory, and it was pointing there.
Comment 11 Michael Bauer 2017-06-24 14:28:20 UTC
Ah ok thanks. Sorry about that, I just had this vision for a moment you restored linguistic content I'd deliberately kicked :)