Bug 108480 - Undo from clone formatting does not remove vertical alignment from cell
Summary: Undo from clone formatting does not remove vertical alignment from cell
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
6.0.0.0.alpha0+ Master
Hardware: All All
: medium normal
Assignee: Not Assigned
QA Contact:
URL:
Whiteboard: target:6.0.0 target:5.4.0.1 target:5.3.5
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-12 12:06 UTC by Tamás Zolnai
Modified: 2017-06-13 19:54 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
Test document with vertical text alignment (11.46 KB, application/vnd.oasis.opendocument.presentation)
2017-06-12 12:06 UTC, Tamás Zolnai
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tamás Zolnai 2017-06-12 12:06:22 UTC
Description:
After using clone formatting and applying vertical aligment on this way on an Impress table's cell and do an undo, vertical aligment is not reverted.

Related to the bug which was fixed the clone formating of vertical alignment:
https://bugs.documentfoundation.org/show_bug.cgi?id=104405

Steps to Reproduce:
1. Open the attached test document
2. Click in the first cell
3. Click clone formating button
4. Click in the second cell -> vertical and horizontal alignment is applied on the second cell
5. Click on Undo icon -> only the horizontal alignment is reverted in the second cell, but the vertical one is not

Actual Results:  
Vertical text alignment is not reverted by undo.

Expected Results:
Vertical text alignment should be reverted by undo.


Reproducible: Always

User Profile Reset: No

Additional Info:


User-Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.110 Safari/537.36
Comment 1 Tamás Zolnai 2017-06-12 12:06:49 UTC
Created attachment 133973 [details]
Test document with vertical text alignment
Comment 2 Xisco Faulí 2017-06-12 16:32:39 UTC
Patch in https://gerrit.libreoffice.org/#/c/38699/
Moving to NEW
Comment 3 Commit Notification 2017-06-12 21:25:51 UTC
Tamás Zolnai committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=37d8ac12902506f4185e10f1de4f566dbaf53e42

tdf#108480: Undo from clone formating does not remove vertical alignment

It will be available in 6.0.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Commit Notification 2017-06-13 09:39:26 UTC
Tamás Zolnai committed a patch related to this issue.
It has been pushed to "libreoffice-5-4":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=cd38a25d41e1ce2acad25b1b5b2a5e77239e36ed&h=libreoffice-5-4

tdf#108480: Undo from clone formating does not remove vertical alignment

It will be available in 5.4.0.1.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2017-06-13 13:57:51 UTC
Tamás Zolnai committed a patch related to this issue.
It has been pushed to "libreoffice-5-3":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=2108184fa798f16269968b32270e4be625200a3b&h=libreoffice-5-3

tdf#108480: Undo from clone formating does not remove vertical alignment

It will be available in 5.3.5.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.