Description: I found that after upgrading LibreOffice to version 5.3, Calc would hang and stop responding during the "calculating" step of opening a specific ODS spreadsheet that worked fine with Calc 5.2 (happened both on a Windows and an openSUSE Linux system after upgrading). I let it run for a night and it hadn't gotten any further the next morning. I managed to isolate the problem to a macro containing something like "If x <> 0. Then". Note that the hang when opening the file occurred before the warning whether macros should be run at all, it seems LibreOffice gets stuck scanning the macro or something. Changing "0." on that line to "0" or "0.0" or removing the macro makes the file open as usual. I found an easier way to reproduce the problem, it seems LibreOffice gets stuck on any macro containing "0.". Just writing "0." in a new macro and trying to save or run it causes LibreOffice to stop responding (the problem is not specific to Calc). Note: I'm not sure whether "0." is actually a valid double constant in LibreOffice BASIC, but it should not hang the program. Steps to Reproduce: 1. Open a new LibreOffice document 2. Go to macro editing: Menu Tools / Macros / Edit Macros (or Organize Macros / LibreOffice Basic / Edit) 3. Write "0." on an empty line (without the quotes, zero followed by period) 4. Press Ctrl+S or F5 Alternate (my original) way to reproduce problem 1. Open macrozerowithperiod.ods (attached) with Calc (I created this file with Calc 5.2 where it works fine) Actual Results: LibreOffice hangs Expected Results: Macros are saved or run macrozerowithperiod.ods file is opened Reproducible: Always User Profile Reset: Yes Additional Info: I have tested a couple of LO versions on different OSes. I can reproduce the problem on Windows 10 (5.3.4.2 and 5.4.0.3), openSUSE Linux (5.3.3.2) and Mac OS X (5.3.4.2). The hang did not occur with 5.2 and earlier versions, I tested Windows 10 (5.2.7.2) and openSUSE Linux (5.2.5.1). User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0
Created attachment 134872 [details] ODS file that causes Calc 5.3 to hang on opening
Regression introduced by: author Eike Rathke <erack@redhat.com> 2016-06-27 19:54:59 (GMT) committer Eike Rathke <erack@redhat.com> 2016-06-27 19:57:52 (GMT) commit 9a6527a98fb968b3fe6bc293ff7520a9480d43d0 (patch) tree 69e8bc1768eca1dcd4fcf783f799e122a2e47a54 parent 1511f5c399182c003c19cc18b316f2fdaac0501d (diff) stringToDouble() do not parse separator without digit as 0.0 Occurred in CSV import without "detect special numbers" activated for data like ,., where the . dot resulted in a numeric cell value 0 Bisected with bibisect-linux-64-5.3 Adding Cc: to Eike Rathke