Bug 111393 - Demuddle googleApiClient in CommunicationServiceWear (findbugs Medium issue)
Summary: Demuddle googleApiClient in CommunicationServiceWear (findbugs Medium issue)
Status: NEW
Alias: None
Product: Impress Remote
Classification: Unclassified
Component: Android Remote App (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: needsDevAdvice
Depends on:
Blocks:
 
Reported: 2017-08-05 10:14 UTC by Andrzej Hunt
Modified: 2022-08-10 03:34 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andrzej Hunt 2017-08-05 10:14:10 UTC
We have a static GoogleApiClient living in CommunicationServiceWear. However its actually treated as a member variable (i.e. should be specific to the instance of CommunicationServiceWear that is being used).

Findbugs rightly complains - I'm planning to suppress that warning for now, but we should somehow unmuddle this:

>Write to static field org.libreoffice.impressremote.communication.CommunicationServiceWear.googleApiClient from instance method org.libreoffice.impressremote.communication.CommunicationServiceWear.onCreate()
> Bug type ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD (click for details)
> In class org.libreoffice.impressremote.communication.CommunicationServiceWear
> In method org.libreoffice.impressremote.communication.CommunicationServiceWear.onCreate()
> Field org.libreoffice.impressremote.communication.CommunicationServiceWear.googleApiClient
> At CommunicationServiceWear.java:[line 61]

googleApiClient needs to (at this time) be static since its used by the (static) presentationPaused()/presentationResumed() implementations. Those in turn are called by SlideShowActivity. It might be simplest for SlideShowActivity to simply have its own googleApiClient which it can use to communicate the pausing/unpausing of the presentation, and then CommunicationServiceWear can de-staticify its own googleApiClient.
Comment 1 Xisco Faulí 2017-08-07 08:53:57 UTC
Moving it back to UNCONFIRMED until someone else confirms it.
Comment 2 QA Administrators 2018-08-09 02:35:06 UTC Comment hidden (obsolete)
Comment 3 QA Administrators 2020-08-09 04:08:10 UTC Comment hidden (obsolete)
Comment 4 QA Administrators 2022-08-10 03:34:44 UTC
Dear Andrzej Hunt,

To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information from Help - About LibreOffice.
 
If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug