Bug 111566 - Password protected .xls files stay in "Read Only" mode even if the password is entered (File Sharing pwd)
Summary: Password protected .xls files stay in "Read Only" mode even if the password i...
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
5.4.0.3 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: notBibisectable, regression
Depends on:
Blocks: Password-Protected
  Show dependency treegraph
 
Reported: 2017-08-09 16:00 UTC by Gitsy
Modified: 2018-10-19 13:56 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
Example XLS (5.50 KB, application/vnd.ms-excel)
2017-08-11 13:56 UTC, Buovjaga
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gitsy 2017-08-09 16:00:53 UTC
Description:
After I upgraded to 5.4. my old xls files which were working fine until LO 5.3 is staying in "Read Only" mode even if the password (File Sharing Password) is entered. The case is same in both Windows and Linux.

Note: The file has no 'File Encryption Password', but have 'File Sharing Password'. 



Steps to Reproduce:
1. open new Calc spreadsheet
2.click 'save'
3. select 'save with password'
4. select format "xls'
5.leave 'File Encryption Password' blank
6. click 'options'
7. enter 'File Sharing Password'(password to allow editing).
8. click 'ok' 
9. close file, close LO 
10.open the created file in LO 5.4
11.a blue banner "This document is open in read-only mode" appear with a button named "Edit Document".
click "Edit Document" and enter the password
12. the blue banner disappears but the xls file stay in "Read Only" mode

Actual Results:  
Even though the 'File Sharing Password'(password to allow editing) is entered, the xls files stay in "Read Only" mode



Expected Results:
Until  LO 5.3 when the the'File Sharing Password'(password to allow editing) is entered, the xls files change from "Read Only" mode to "edit mode"


Reproducible: Always

User Profile Reset: No

Additional Info:


User-Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.90 Safari/537.36
Comment 1 Buovjaga 2017-08-11 13:56:55 UTC
Created attachment 135471 [details]
Example XLS

Password is 1234

Reproduced.

Arch Linux 64-bit, KDE Plasma 5
Version: 5.4.0.3
Build ID: 5.4.0-1
CPU threads: 8; OS: Linux 4.12; UI render: default; VCL: kde4; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group

Arch Linux 64-bit, KDE Plasma 5
Version: 6.0.0.0.alpha0+
Build ID: db17a874af37350b3270932175854ee674447bc1
CPU threads: 8; OS: Linux 4.12; UI render: default; VCL: kde4; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group
Built on August 11th 2017
Comment 2 Xisco Faulí 2017-08-11 20:45:39 UTC
Before aa8efc72d43c2000cb3b5571fdc6b48617eb9b94 it worked correctly and the infobar was displayed. Then it disappeared until 630186ff4e0eba7317e542f8c3eca39ebd068721 when it was displayed again, and the problem is already reproducible at this point.

@Samuel: would you mind taking a look at this?
Comment 3 QA Administrators 2018-09-14 02:47:08 UTC Comment hidden (obsolete, spam)
Comment 4 Justin L 2018-10-19 09:12:39 UTC
Using the document in comment 1, I am not able to reproduce. It opens with the blue ribbon prompt to "edit document". The password is accepted and editing is possible ever since LO 6.0's commit 630186ff4e0eba7317e542f8c3eca39ebd068721 (mentioned in comment 2 - I also confirm that the blue ribbon disappeared in LO 5.4 at commit aa8efc72d43c2000cb3b5571fdc6b48617eb9b94).

What does NOT work still in 6.2alpha is following comment 0's steps.  When I save as a new document with read-only and only a file-sharing password, then the document opens in read-only mode without any prompt.  So, 6.2 alpha differs from OP's step 11.

Seemingly unrelated to bug 114221, there might be some clues there about where to look or what other password changes have been happening in the 5.3/5.4 timeframe.
Comment 5 Justin L 2018-10-19 13:18:21 UTC
I think this one can probably be marked as WorksForMe because entering the password does kick it out of readonly mode, which is the main complaint. The blue "Edit Document" not showing up any more is intentional - see for example bug 91068.

See bug 106366 for the commit that prevents the blue bar from showing up at step 11.
Comment 6 Buovjaga 2018-10-19 13:56:46 UTC
Fair enough, let's close.