Description: After I upgraded to 5.4. my old xls files which were working fine until LO 5.3 is staying in "Read Only" mode even if the password (File Sharing Password) is entered. The case is same in both Windows and Linux. Note: The file has no 'File Encryption Password', but have 'File Sharing Password'. Steps to Reproduce: 1. open new Calc spreadsheet 2.click 'save' 3. select 'save with password' 4. select format "xls' 5.leave 'File Encryption Password' blank 6. click 'options' 7. enter 'File Sharing Password'(password to allow editing). 8. click 'ok' 9. close file, close LO 10.open the created file in LO 5.4 11.a blue banner "This document is open in read-only mode" appear with a button named "Edit Document". click "Edit Document" and enter the password 12. the blue banner disappears but the xls file stay in "Read Only" mode Actual Results: Even though the 'File Sharing Password'(password to allow editing) is entered, the xls files stay in "Read Only" mode Expected Results: Until LO 5.3 when the the'File Sharing Password'(password to allow editing) is entered, the xls files change from "Read Only" mode to "edit mode" Reproducible: Always User Profile Reset: No Additional Info: User-Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.90 Safari/537.36
Created attachment 135471 [details] Example XLS Password is 1234 Reproduced. Arch Linux 64-bit, KDE Plasma 5 Version: 5.4.0.3 Build ID: 5.4.0-1 CPU threads: 8; OS: Linux 4.12; UI render: default; VCL: kde4; Locale: fi-FI (fi_FI.UTF-8); Calc: group Arch Linux 64-bit, KDE Plasma 5 Version: 6.0.0.0.alpha0+ Build ID: db17a874af37350b3270932175854ee674447bc1 CPU threads: 8; OS: Linux 4.12; UI render: default; VCL: kde4; Locale: fi-FI (fi_FI.UTF-8); Calc: group Built on August 11th 2017
Before aa8efc72d43c2000cb3b5571fdc6b48617eb9b94 it worked correctly and the infobar was displayed. Then it disappeared until 630186ff4e0eba7317e542f8c3eca39ebd068721 when it was displayed again, and the problem is already reproducible at this point. @Samuel: would you mind taking a look at this?
** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
Using the document in comment 1, I am not able to reproduce. It opens with the blue ribbon prompt to "edit document". The password is accepted and editing is possible ever since LO 6.0's commit 630186ff4e0eba7317e542f8c3eca39ebd068721 (mentioned in comment 2 - I also confirm that the blue ribbon disappeared in LO 5.4 at commit aa8efc72d43c2000cb3b5571fdc6b48617eb9b94). What does NOT work still in 6.2alpha is following comment 0's steps. When I save as a new document with read-only and only a file-sharing password, then the document opens in read-only mode without any prompt. So, 6.2 alpha differs from OP's step 11. Seemingly unrelated to bug 114221, there might be some clues there about where to look or what other password changes have been happening in the 5.3/5.4 timeframe.
I think this one can probably be marked as WorksForMe because entering the password does kick it out of readonly mode, which is the main complaint. The blue "Edit Document" not showing up any more is intentional - see for example bug 91068. See bug 106366 for the commit that prevents the blue bar from showing up at step 11.
Fair enough, let's close.