Bug 111737 - Not possible to create / add a new Master Slide with pressing Enter in slides/pages pane
Summary: Not possible to create / add a new Master Slide with pressing Enter in slides...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium normal
Assignee: Andreas Heinisch
URL:
Whiteboard: target:24.2.0
Keywords:
Depends on:
Blocks: Slide-Page-Pane Impress-UX
  Show dependency treegraph
 
Reported: 2017-08-12 17:38 UTC by Telesto
Modified: 2023-10-23 16:45 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot Draw's Master View (44.13 KB, image/png)
2017-08-12 22:50 UTC, m_a_riosv
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2017-08-12 17:38:00 UTC
Description:
In Normal View a slide/page can be added pressing enter in the Slide/Page panel. The same behavior doesn't exist in Master View.

Steps to Reproduce:
1. Open Draw
2. Go to View -> Master
3. Press Enter

Actual Results:  
No new page added

Expected Results:
A new page should be added (for consistency reasons)


Reproducible: Always

User Profile Reset: No

Additional Info:
Version: 6.0.0.0.alpha0+
Build ID: 46b4eb8b0e9325f8c29cd391baf9504bccee1837
CPU threads: 4; OS: Windows 6.19; UI render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2017-08-11_06:44:17
Locale: nl-NL (nl_NL); Calc: CL


User-Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:52.0) Gecko/20100101 Firefox/52.0
Comment 1 m_a_riosv 2017-08-12 22:50:01 UTC
Created attachment 135504 [details]
Screenshot Draw's Master View

For me 'Master View' toolbar appears with a button for 'Add' and another for 'Rename'
Comment 2 Telesto 2017-08-13 07:49:25 UTC
(In reply to m.a.riosv from comment #1)
> Created attachment 135504 [details]
> Screenshot Draw's Master View
> 
> For me 'Master View' toolbar appears with a button for 'Add' and another for
> 'Rename'

That's true. Normal View also has a toolbar. The minor/trivial part is that no sheet can be added by pressing 'Enter'. It could be on purpose; a distinction between Master View and Normal View. But it shouldn't be done this way, in my opinion.
Comment 3 Heiko Tietze 2017-08-31 11:53:27 UTC
For consistency I would enable the add slide with enter feature also in master mode.
Comment 4 Heiko Tietze 2017-09-21 13:13:11 UTC Comment hidden (no-value, wrong-bug-id)
Comment 5 QA Administrators 2018-09-27 02:42:26 UTC Comment hidden (obsolete)
Comment 6 Roman Kuznetsov 2018-09-27 07:31:21 UTC
still repro in 

Version: 6.2.0.0.alpha0+
Build ID: 1aa37aa6bee19099b57555a6d839992b054aa405
CPU threads: 4; OS: Windows 6.1; UI render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2018-09-23_10:17:54
Locale: ru-RU (ru_RU); Calc: threaded
Comment 7 QA Administrators 2019-09-28 03:04:59 UTC Comment hidden (obsolete)
Comment 8 Cor Nouws 2021-09-13 16:20:07 UTC
Still the same in most recent version.
Comment 9 QA Administrators 2023-09-14 03:05:44 UTC Comment hidden (obsolete)
Comment 10 Commit Notification 2023-10-23 16:44:43 UTC
Andreas Heinisch committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/ea574f7929d4c226d56273178779ef38ca2ce5c9

tdf#111737 - Add new (master) page depending on the edit mode

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Andreas Heinisch 2023-10-23 16:45:43 UTC
Unfortunately, the slidesorter has no support for an ui test.