Bug 112649 - EDITING Canceling Add rows in Chart data table does not cancel the action
Summary: EDITING Canceling Add rows in Chart data table does not cancel the action
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Chart (show other bugs)
Version:
(earliest affected)
5.3.0.1 rc
Hardware: All All
: medium minor
Assignee: Not Assigned
URL:
Whiteboard: target:6.4.0
Keywords:
Depends on:
Blocks: Chart-Data
  Show dependency treegraph
 
Reported: 2017-09-25 16:44 UTC by Emil Tanev
Modified: 2023-09-13 00:30 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Emil Tanev 2017-09-25 16:44:36 UTC
Open Writer
Add a Chart
Click Data Table
Add a few rows
Click Cancel

Issue: The Insert rows is not canceled and the rows remain. 
Screencast

https://www.screencast.com/t/bRAUBmTCqAnt


Version: 5.4.1.2 (x64)
Build ID: ea7cb86e6eeb2bf3a5af73a8f7777ac570321527
CPU threads: 8; OS: Windows 6.19; UI render: default;
Comment 1 Jacques Guilleron 2017-09-26 14:13:43 UTC
Hi Emil,

Reproduced with
LO 5.4.1.2 (x64) Build ID: ea7cb86e6eeb2bf3a5af73a8f7777ac570321527
CPU threads: 2; OS: Windows 6.1; UI render: default; 
Locale: en-US (fr_FR); Calc: CL
Those buttons were added into
LO 4.3.0.1 Build ID: 67f5430184326974072b65403ef1d9d934fc4481.
Observed: Still in edit mode, once tried the delete button, Ctrl+Z, Undo in Edit menu, operate.
Even once left, if you edit again the diagram, undo(Ctrl+Z) can be accessed.
Thanks you to have reported it.
Comment 2 QA Administrators 2018-09-27 02:42:36 UTC Comment hidden (obsolete)
Comment 3 Roman Kuznetsov 2018-09-27 07:51:44 UTC
still repro in 

Version: 6.2.0.0.alpha0+
Build ID: 1aa37aa6bee19099b57555a6d839992b054aa405
CPU threads: 4; OS: Windows 6.1; UI render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2018-09-23_10:17:54
Locale: ru-RU (ru_RU); Calc: threaded
Comment 4 QA Administrators 2021-03-19 04:41:03 UTC Comment hidden (obsolete)
Comment 5 QA Administrators 2023-03-20 03:26:39 UTC Comment hidden (obsolete)
Comment 6 Stéphane Guillou (stragu) 2023-09-13 00:30:45 UTC
Repro in 6.3.6.2, but not since 6.4.7.2 as the Cancel and OK button were replaced by a single Close button.

Caolán's DataEditor weld fixed it in aa7e7747f4296b3b92379c3c7703b80ad8af6a8b.
Thanks Caolán!

Undo-redo always worked.