Bug 113008 - Change button text from OK to Sign in Sign Document dialog
Summary: Change button text from OK to Sign in Sign Document dialog
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
5.4.1.2 release
Hardware: All All
: medium normal
Assignee: Srijita
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Digital-Signatures
  Show dependency treegraph
 
Reported: 2017-10-09 08:51 UTC by Dmitry
Modified: 2021-01-31 13:29 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:
Regression By:


Attachments
Signature (299.99 KB, image/png)
2021-01-31 12:55 UTC, Srijita
Details
Sign (12.74 KB, image/png)
2021-01-31 12:56 UTC, Srijita
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry 2017-10-09 08:51:17 UTC
Steps to reproduce:
* I opened PDF via "File → Digital Signatures → Sign Existing PDF". It shows me PDF in read-only mode [OK].
* There is a tooltip provided with a button "Sign Document". I click this button, click "Sign Document..." in the bottom of the dialog, choose the key and press "OK". Then I click "Close" to close "Digital signatures" dialog.

As far as I understand PDF is saved back to disk (I've checked file modification date). However from users' perspective it is not expected that "Close" dialog button performs "Save" action. Also after the dialog is closed it is not clear if the user has to perform extra action to save the document.

Expected: UI is organized in different way (for example, there is a button "Sign & Save"), or the user is somehow communicated that the document is saved.

Further:
* Go to "File → Export as PDF".

Expected: The certificate which I have selected in step above is already set to tab "Digital Signatures", however it is not.
Comment 1 Heiko Tietze 2018-01-03 10:41:15 UTC
How about just renaming Ok to Sign?
Comment 2 Heiko Tietze 2018-09-12 07:43:26 UTC
Removing needsUX; changing labels is an easyhack.
Comment 3 Srijita 2021-01-29 09:19:14 UTC
I would like to work on this.
Comment 4 Srijita 2021-01-31 11:36:44 UTC
Where can I find the relevant source code files? Is it in cui/uiconfig/ui ?
Comment 5 Buovjaga 2021-01-31 12:02:32 UTC
(In reply to Srijita from comment #4)
> Where can I find the relevant source code files? Is it in cui/uiconfig/ui ?

Search for the string "Sign Document" in the code
Comment 6 Srijita 2021-01-31 12:48:38 UTC
(In reply to Buovjaga from comment #5)
> (In reply to Srijita from comment #4)
> > Where can I find the relevant source code files? Is it in cui/uiconfig/ui ?
> 
> Search for the string "Sign Document" in the code

I searched for "Sign Document" and found two relevant files cui/uiconfig/ui/ signatureline.ui   and  cui/uiconfig/ui/signsignatureline.ui containing the dialog box. Am I correct that these files have to be modified?
Comment 7 Srijita 2021-01-31 12:54:42 UTC
Also when I open the Digital Signatures dialog box I observed that:
- Sign Document no certificate is showing 
- And if I click on Start Certificate manager to add certificate its prompting GnuPG keys are empty and there is no way to add also

(Please see the images in Attachments section above)
Comment 8 Srijita 2021-01-31 12:55:51 UTC
Created attachment 169328 [details]
Signature
Comment 9 Srijita 2021-01-31 12:56:27 UTC
Created attachment 169329 [details]
Sign
Comment 10 Buovjaga 2021-01-31 13:29:47 UTC
(In reply to Heiko Tietze from comment #1)
> How about just renaming Ok to Sign?

Hmm, now I tested and the button already says "Sign"! So somebody already renamed the button text. Let's close this.