Steps to reproduce: * I opened PDF via "File → Digital Signatures → Sign Existing PDF". It shows me PDF in read-only mode [OK]. * There is a tooltip provided with a button "Sign Document". I click this button, click "Sign Document..." in the bottom of the dialog, choose the key and press "OK". Then I click "Close" to close "Digital signatures" dialog. As far as I understand PDF is saved back to disk (I've checked file modification date). However from users' perspective it is not expected that "Close" dialog button performs "Save" action. Also after the dialog is closed it is not clear if the user has to perform extra action to save the document. Expected: UI is organized in different way (for example, there is a button "Sign & Save"), or the user is somehow communicated that the document is saved. Further: * Go to "File → Export as PDF". Expected: The certificate which I have selected in step above is already set to tab "Digital Signatures", however it is not.
How about just renaming Ok to Sign?
Removing needsUX; changing labels is an easyhack.
I would like to work on this.
Where can I find the relevant source code files? Is it in cui/uiconfig/ui ?
(In reply to Srijita from comment #4) > Where can I find the relevant source code files? Is it in cui/uiconfig/ui ? Search for the string "Sign Document" in the code
(In reply to Buovjaga from comment #5) > (In reply to Srijita from comment #4) > > Where can I find the relevant source code files? Is it in cui/uiconfig/ui ? > > Search for the string "Sign Document" in the code I searched for "Sign Document" and found two relevant files cui/uiconfig/ui/ signatureline.ui and cui/uiconfig/ui/signsignatureline.ui containing the dialog box. Am I correct that these files have to be modified?
Also when I open the Digital Signatures dialog box I observed that: - Sign Document no certificate is showing - And if I click on Start Certificate manager to add certificate its prompting GnuPG keys are empty and there is no way to add also (Please see the images in Attachments section above)
Created attachment 169328 [details] Signature
Created attachment 169329 [details] Sign
(In reply to Heiko Tietze from comment #1) > How about just renaming Ok to Sign? Hmm, now I tested and the button already says "Sign"! So somebody already renamed the button text. Let's close this.