Bug Hunting Session
Bug 113434 - Two fill color controls in Drawing Object Properties toolbar
Summary: Two fill color controls in Drawing Object Properties toolbar
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
5.4.2.2 release
Hardware: All All
: medium normal
Assignee: Yousuf Philips (jay) (retired)
URL:
Whiteboard: target:6.0.0
Keywords:
Depends on:
Blocks: Writer-Toolbars Split-Group-Buttons-Color
  Show dependency treegraph
 
Reported: 2017-10-25 09:10 UTC by Christian Lehmann
Modified: 2017-10-26 01:13 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Lehmann 2017-10-25 09:10:40 UTC
Description:
The Drawing Object Properties bar in my German Writer 5.4.2.2 has (among others) these two symbols:
- one pot with a downwards arrow head which says "Füllfarbe" (filling color),
- another pot beside a colored bar and a downwards arrow head, which also says "Füllfarbe".
- If I change the first, the second changes likewise.
- If I change the second, nothing else happens.
This is relatively confusing:
- If these menu items have distinct functionality, then render this clear in their handling and assign them different names.
- If they have the same functionality, merge them.


Steps to Reproduce:
1. Click on a graphics figure to show Drawing Object Properties bar.


Actual Results:  
An inconsistent menu bar appeared.

Expected Results:
Assign distinct functions to distinct symbols and merge identical functions into one symbol.


Reproducible: Always

User Profile Reset: No

Additional Info:


User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:56.0) Gecko/20100101 Firefox/56.0
Comment 1 Yousuf Philips (jay) (retired) 2017-10-25 12:04:16 UTC
Yes both were essential in 4.4, the second control at that time didnt give access to the color picker widget pulldown, but starting from 5.0 the first one became redundant.

https://gerrit.libreoffice.org/43828
Comment 2 Commit Notification 2017-10-26 01:13:16 UTC
Yousuf Philips committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=91c8acaacf3846169d1e58c03acc5c20cd79a257

tdf#81475 tdf#113434 improve drawing object toolbar

It will be available in 6.0.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.