Bug 113594 - Glue points can not be selected and therefore not edited (move, delete, orientation)
Summary: Glue points can not be selected and therefore not edited (move, delete, orien...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Draw (show other bugs)
Version:
(earliest affected)
5.4.0.3 release
Hardware: All All
: high normal
Assignee: Mark Hung
URL:
Whiteboard: target:6.1.0 target:6.0.0.1 target:5.4.5
Keywords: bibisected, bisected, regression
: 114757 115089 115220 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-11-02 11:03 UTC by Jürgen Mähnß
Modified: 2018-01-25 09:45 UTC (History)
10 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jürgen Mähnß 2017-11-02 11:03:38 UTC
Description:
When you add a form like a star it is possible to add glue points to the tips of the star. 
- The points do not appear instantaneously but only after deselectiong the glue symbol and reselecting it.
- The points can not be selected so editing is not possible

Steps to Reproduce:
1. Add a star
2. choose glue tool
3. select the star
4. choose add glue point
5. add glue points to tips of star - they are not visible
6. deselect glue tool
7. select glue tool - glue points are visible but can't be selected for further editing

Actual Results:  
glue points are not selectable for furher editing

Expected Results:
select a glue point for moving, orientation setting ore deletion


Reproducible: Always


User Profile Reset: Yes


OpenGL enabled: Yes

Additional Info:
Version: 5.4.2.2 (x64)
Build-ID: 22b09f6418e8c2d508a9eaf86b2399209b0990f4
CPU-Threads: 6; Betriebssystem:Windows 6.19; UI-Render: Standard; 
Gebietsschema: de-DE (de_DE); Calc: group


User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0
Comment 1 Regina Henschel 2017-11-02 12:50:40 UTC
I can confirm the error in Version: 5.4.0.3
Build ID: 7556cbc6811c9d992f4064ab9287069087d7f62c
CPU threads: 4; OS: Windows 6.1; UI render: default; 
Locale: de-DE (de_DE); Calc: group

It was OK in Version: 5.3.5.2
Build ID: 50d9bf2b0a79cdb85a3814b592608037a682059d
CPU Threads: 4; OS Version: Windows 6.1; UI Render: default; Layout Engine: new; 
Locale: de-DE (de_DE); Calc: group
Comment 2 Regina Henschel 2017-11-02 14:02:47 UTC
Fails in Version: 5.4.0.0.alpha1+
Build ID: 965494c544dd8f35ae83b7cf38549009da06c367
CPU threads: 4; OS: Windows 6.1; UI render: default; 
TinderBox: Win-x86@62-TDF, Branch:MASTER, Time: 2017-05-10_23:06:27
Locale: de-DE (de_DE); Calc: group

OK in Version: 5.4.0.0.alpha0+
Build ID: 597a2f5d5bd37443262b0775b8439bc3502aef1b
CPU threads: 4; OS: Windows 6.1; UI render: default; 
TinderBox: Win-x86@62-TDF, Branch:MASTER, Time: 2017-04-26_22:29:37
Locale: de-DE (de_DE); Calc: group
Comment 3 Daniel 2017-12-01 11:32:19 UTC
I can confirm this bug for version 5.4.3 on Windows. Another way of making newly added glue points visible is to scroll that part of the drawing out of the visible window and scrolling back again; or zooming, forcing a repaint. Glue points cannot be changed or deleted, so it is not possible to e.g. set the connecting direction for a new glue point.

Glue points work fine in version 5.3.7.
Comment 4 Aron Budea 2017-12-03 22:09:18 UTC
Bibisected to the commit referenced below using repo bibisect-win32-5.4. Adding Cc: to Noel Grandin, please take a look sometimes.
I'm assuming the bug isn't Win-specific unless someone confirms the opposite.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=ec38966951f28a1e1d4c97f01a550c87f152cbc8
author		Noel Grandin <noel.grandin@collabora.co.uk>	2017-05-04 14:29:10 +0200
committer	Noel Grandin <noel.grandin@collabora.co.uk>	2017-05-05 08:50:27 +0200

loplugin:checkunusedparams in svx(part3)
Comment 5 Rene Engelhard 2017-12-15 09:44:21 UTC
probably not, no, see also http://bugs.debian.org/883989 (which I just marked as upstream, forwarded to this bug)

https://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-6-0&id=715d0f32eb36593a4c9e52763b2ceb17ec1283c5 is supposed to fix it according to the commit message....
Comment 6 Gerhard Schaber 2017-12-21 09:52:33 UTC
It would be great, if the fix was back-ported to 5.4.
Comment 7 Aron Budea 2017-12-21 14:14:22 UTC
Fixed by the following commits in master and libreoffice-6-0:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=bf151f0716910b56e3538579f4af7ede8f51bbcf

https://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-6-0&id=715d0f32eb36593a4c9e52763b2ceb17ec1283c5

Backport to 5.4 is in gerrit.

Thanks for the fix, Mark!
Comment 9 Julien Nabet 2018-01-25 09:41:22 UTC
*** Bug 115220 has been marked as a duplicate of this bug. ***
Comment 10 Julien Nabet 2018-01-25 09:43:52 UTC
*** Bug 115089 has been marked as a duplicate of this bug. ***
Comment 11 Julien Nabet 2018-01-25 09:45:06 UTC
*** Bug 114757 has been marked as a duplicate of this bug. ***