Bug 114023 - Insert -> Field -> More Fields, or <ctrl>+<f2>, Fields dialog showing incorrect selection listbox contents
Summary: Insert -> Field -> More Fields, or <ctrl>+<f2>, Fields dialog showing incorre...
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.0.0.0.alpha0+
Hardware: x86-64 (AMD64) All
: high major
Assignee: Caolán McNamara
URL:
Whiteboard: target:6.1.0 target:6.0.0.1
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Fields-Dialog
  Show dependency treegraph
 
Reported: 2017-11-24 13:25 UTC by Thomas Krumbein
Modified: 2019-09-23 11:16 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:


Attachments
old "correct" list - new list (66.35 KB, image/png)
2017-11-24 13:25 UTC, Thomas Krumbein
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Krumbein 2017-11-24 13:25:13 UTC
Description:
Incorrect Content in Dialog "Insert Fields". Checked as an example:

DocumentInfo: Created  ->  Selection list does not fit to field. 

Same in all other fields in that list. sometimes no selection possible, sometimes the same wrong list appears.

Steps to Reproduce:
1.open dialog "Insert feilds" _> document info
2.
3.

Actual Results:  
see screeshot

Expected Results:
see screeshot


Reproducible: Always


User Profile Reset: Yes



Additional Info:


User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0
Comment 1 Thomas Krumbein 2017-11-24 13:25:42 UTC
Created attachment 137965 [details]
old "correct" list - new list
Comment 2 Dieter 2017-11-24 16:05:06 UTC
I confirm it with LO 6.0.0.0. It is also correct in LO 5.4.3.
Comment 3 V Stuart Foote 2017-11-24 18:02:01 UTC
Looks as if the DocInformation tab "Select" listbox is being populated with LB selections from the "Insert _reference to" targets of the Cross-references tab of the dialog.

Affects the listbox for the Created, Last Printed, and Modified fields.

The .UI files seem correct.

Correct through the 5.4.3 release, bad in 6.0.0 master, a bibisect would be helpful.
Comment 4 Julien Nabet 2017-11-24 20:32:15 UTC
Caolán: thought you might be interested in this one. I'm not sure but wonder if it could be related to boost::gettext part. Of course, I'm not sure, it's more a guess.
Comment 5 Julien Nabet 2017-11-24 20:36:00 UTC
Let's increase the importance since it's a regression + concerns all env.
Comment 6 V Stuart Foote 2017-11-24 21:34:24 UTC
Bibisect from builds on hand, appears between 2017-07-21 and 2017-07-23, looks like Noel had been cleaning up some of the field crud in that time frame.

https://cgit.freedesktop.org/libreoffice/core/log/?qt=range&q=a9588baca8137f51e2ca72e40b1f448b0e1885d1..28b382b7b0a32417e0aedd4ae415a69e479fe60b
Comment 7 Xisco Faulí 2017-11-24 23:38:00 UTC
Regression introduced by:

author	Caolán McNamara <caolanm@redhat.com>	2017-06-11 19:56:30 (GMT)
committer	Caolán McNamara <caolanm@redhat.com>	2017-07-21 07:20:50 (GMT)
commit 00657aef09d854c74fb426a935a3e8b1fc390bb0 (patch)
tree fd1a9bb264fe15dcc129498e62060ecd256b1ee7
parent fa987cbb813cfd729fe490f2f1258b7c8d7fb174 (diff)
migrate to boost::gettext

Bisected with: bibisect-linux64-6.0

Adding Cc: to Caolán McNamara
Comment 8 Commit Notification 2017-11-27 14:30:44 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=2d8fd07152210d5c8ea9825ba7a28b5f72163488

tdf#114023 typo of FMT_REF_ARY instead of FMT_REG_ARY

It will be available in 6.0.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Commit Notification 2017-11-27 14:33:43 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-6-0":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=6d41b03311355f1f7517359879eb980071d52463&h=libreoffice-6-0

tdf#114023 typo of FMT_REF_ARY instead of FMT_REG_ARY

It will be available in 6.0.0.1.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Julien Nabet 2017-11-28 17:53:21 UTC
On pc Debian x86-64 with master sources updated today, I don't reproduce this.

Remark: I just noticed "Paragraph Signature" part is empty but perhaps it's an WIP.

Thank you Caolán for the quick fix!
Comment 11 Dieter 2019-09-23 11:16:25 UTC
(In reply to Julien Nabet from comment #10)
> On pc Debian x86-64 with master sources updated today, I don't reproduce
> this.

=> VERIFIED FIXED