Bug 114078 - Numbering format strings no longer found in pootle
Summary: Numbering format strings no longer found in pootle
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Localization (show other bugs)
Version:
(earliest affected)
6.0.0.0.alpha1+
Hardware: All All
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:6.1.0 target:6.0.0.1
Keywords:
Depends on:
Blocks: Numbering-Formats
  Show dependency treegraph
 
Reported: 2017-11-26 22:54 UTC by Yousuf Philips (jay) (retired)
Modified: 2017-11-27 20:34 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Numbering drop-down list items not localized nor localizable anymore. (88.30 KB, image/png)
2017-11-26 23:28 UTC, Martin Srebotnjak
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Yousuf Philips (jay) (retired) 2017-11-26 22:54:42 UTC
The strings found in numberingtype.hrc[1] are no longer found in pootle, though the qtz language pack shows them with key ids.

[1] https://opengrok.libreoffice.org/xref/core/svx/inc/numberingtype.hrc#29
Comment 1 Martin Srebotnjak 2017-11-26 23:28:01 UTC
Created attachment 138004 [details]
Numbering drop-down list items not localized nor localizable anymore.
Comment 2 Martin Srebotnjak 2017-11-26 23:28:24 UTC
I can confirm with Slovenian LO60b1 on macOS, which should be fully localized based on November 24, 2017 master state.
With my l10n system I can see these strings were available in svx/messages.pot on September 14, 2017, but were already missing on September 22.

See attached screenshot.
Comment 3 V Stuart Foote 2017-11-27 02:06:26 UTC
IIUC that is expected for some of the new "conversions" to .hrc with the change to boost::gettext, see its description [1] -- numberingtype.hrc replaced numberingtype.src

So, assume supporting plumbing changes were needed to feed Pootle? Were provisions for the new .hrc missed?

[1] https://cgit.freedesktop.org/libreoffice/core/commit/?id=00657aef09d854c74fb426a935a3e8b1fc390bb0
Comment 4 Caolán McNamara 2017-11-27 12:34:21 UTC
its a bug of missing markup in the .hrc
Comment 5 Commit Notification 2017-11-27 14:32:11 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=204fba299abfb48b699134e127933a2558319801

tdf#114078 Missing gettext markup on Numbering format strings

It will be available in 6.0.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2017-11-27 14:33:54 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-6-0":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=0730121f374f1bc4714f2cdb21b6cab52a401149&h=libreoffice-6-0

tdf#114078 Missing gettext markup on Numbering format strings

It will be available in 6.0.0.1.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.